Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jun 24, 2025

What's Changed

This PR aims to focus on real errors by removing -warnings-as-errors flag.

To make it sure, this PR removes the following from CI test pipelines.

# We remove this when we support Swift 6.0 or later.
continue-on-error: ${{ matrix.swift-version != '5.10' }}

We can enable -warnings-as-errors later .

@dongjoon-hyun
Copy link
Member Author

cc @kou

@dongjoon-hyun dongjoon-hyun changed the title chore: Focus on errors by ignoring warnings chore: Focus on real errors by ignoring warnings Jun 24, 2025
@dongjoon-hyun dongjoon-hyun changed the title chore: Focus on real errors by ignoring warnings chore: Focus on actual errors by ignoring warnings Jun 24, 2025
@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jun 24, 2025

All Swift versions (5.10, 6.0, 6.1) passed.

Screenshot 2025-06-24 at 08 26 18

Instead of focusing on warnings, we need to focus other stuffs first. For example,

If you don't mind, why don't we call it a day for Swift 6.x support with this PR, @kou ?

@dongjoon-hyun dongjoon-hyun changed the title chore: Focus on actual errors by ignoring warnings chore: Focus on actual errors by removing -warnings-as-errors Jun 24, 2025
@kou
Copy link
Member

kou commented Jun 25, 2025

Hmm. I don't want to remove this as much as possible to keep healthy code.

@dongjoon-hyun
Copy link
Member Author

Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants