-
Notifications
You must be signed in to change notification settings - Fork 8
Prepare release scripts #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Closes apache#9.
I tried this workflow on my fork:
|
I'll merge this in a few days if nobody objects it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @kou I haven't had much time to go through it.
In general looks good to me, I have a question about the npm publishing and having the possibility to retry it.
We can also add that functionality of retrying npm as a separate PR or an improvement if you think is best.
dev/release/release.sh
Outdated
"https://dist.apache.org/repos/dist/release/arrow/${old_release_version}" | ||
done | ||
|
||
echo "Publish to npm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we have an option to only publish to npm and avoid the rest?
I've had to retry the publishing npm script in the past due to timeouts our random failures with OTP login and seems worth to me.
Either that or split this in a two steps process?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense. I've added RELEASE_*
environment variables.
Co-authored-by: Raúl Cumplido <[email protected]>
No problem. Thanks for your review! |
I'll merge this. |
What's Changed
This is based on the release scripts used by apache/arrow-java:
https://github.com/apache/arrow-java/tree/main/dev/release
Here is the release workflow:
package.json
dev/release/release_rc.sh 1
vX.Y.Z-rc1
tag[email protected]
dev/release/release.sh 1
after the vote carriedvX.Y.Z
tagSee also the added
dev/release/README.md
.Closes #9.