[Java] ErrorProne Warnings to be considered as Errors

[vibhatha]

Describe the enhancement requested

Even though we have integrated the ErrorProne module in each module, we still see iterative development cycle introduces more warnings, and to avoid this it would be better to error them so that in the development time these are properly tracked and addressed. This must be done for each module.

• Algorithm
• [Java] Consider warnings as errors for Adapter Module arrow#43962
• [Java] Consider warnings as errors for C Module arrow#44011
• Compression
• [Java] Consider warnings as errors for Dataset Module arrow#44013
• Flight
• [Java] Consider warnings as errors for Format Module arrow#44016
• Memory (cannot be done: explained here)
• Performance
• [Java] Consider warnings as errors for Vector Module arrow#44044
• Gandiva
• [Java] Finalize ErrorProne Warnings to be considered as Errors #53

Component(s)

Java

[vibhatha]

@lidavidm looking into the available flags we do have the following https://errorprone.info/docs/flags

For instance, the available flags don't seem to have something like an error warning, rather it has -XepAllErrorsAsWarnings. Not sure if we have an option the other way around? But we can do it manually for each category of warnings like -Xep:MissingOverride:ERROR. But this requires making a list of items that may not cover all the angles we hope for. Still needs further investigation...

[lidavidm]

Um, (1) warnings-as-errors is just a javac option (2) my original concern wasn't about the errorprone warnings, it was just about the regular javac deprecation warnings.

[vibhatha]

I see, I have misunderstood it. Either way, I will make the improvements on both fronts as required. And I will investigate about (1) and how to add that.