Skip to content

Conversation

@okaybase
Copy link
Member

@okaybase okaybase commented Aug 12, 2021

What this PR does / why we need it:

Add custom reject-message for traffic control, service provider can tell the caller what happens.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@okaybase okaybase requested a review from spacewander August 12, 2021 07:44
@okaybase okaybase requested a review from spacewander August 12, 2021 14:09
@tzssangglass
Copy link
Member

@spacewander I think we need to unify the rejected_code and rejected_msg attributes of the limit-req, limit-conn and limit-count.

At present they look somewhat incongruous.

@okaybase okaybase requested a review from tzssangglass August 12, 2021 15:33
@okaybase okaybase requested a review from spacewander August 13, 2021 02:52
@spacewander spacewander changed the title feat(plugin): add custom reject-message for traffic control feat(limit-*): add custom reject-message for traffic control Aug 13, 2021
@spacewander spacewander merged commit b7cbaed into apache:master Aug 13, 2021
@okaybase okaybase deleted the return-value branch August 13, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants