Change the default celery worker_concurrency to 16 #13612
Conversation
I think this change was unintentional -- apache#7205 That PR just changed it to work with breeze. Since we had `16` as default in 1.10.x and to get better performance and keep in line with `dag_concurrency` and `max_active_runs_per_dag` -- I think `16` makes more sense.
|
|
||
| ## Master | ||
|
|
||
| ### Default `[celery] worker_concurrency` is changed to `16` |
There was a problem hiding this comment.
Can we also add env variable to set the ''8" value in entrypoint_ci.sh - the number of celery workers also impacts the tests run in GitHub so it would be great to keep the lower value there to keep stability.
There was a problem hiding this comment.
worker_concurrency is not the number of workers required -- it is the number of task_instances each Celery Workers will run
There was a problem hiding this comment.
I have pushed 49a71e1 to change the default for tests to 8 -- but I don't see a reason why it should be less than the default in tests
There was a problem hiding this comment.
I cannot recall exactly, we can ask @turbaszek, but I believe this was due to stability for some tests in CI that were failing intermittently (likely due to memory issues) when the worker_concurrency was too high and it was easier to change the default value rather than fix the tests (which were simply flaky)
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
This change was unintentional -- apache#7205 That PR just changed it to work with breeze. Since we had `16` as default in 1.10.x and to get better performance and keep in line with `dag_concurrency` and `max_active_runs_per_dag` -- I think `16` makes more sense. (cherry picked from commit 6c458f2) (cherry picked from commit 6f8f23a)
4 participants
I think this change was unintentional -- #7205
That PR just changed it to work with breeze. Since we had
16as default in 1.10.xand to get better performance and keep in line with
dag_concurrencyandmax_active_runs_per_dag-- I think16makes more sense.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.