Add a Reset Password button under Security > List Users > Edit user

[ecerulm]

Description

Currently the way to reset the password via the UI is to go to Security > List Users > Show record (loupe icon) > Show User > Reset Password

I think it's counterintuitive that the reset password button is only there, and not in under the Edit record > Edit User

So I believe it would be better if the reset password button is show in both Show User and Edit User.

Use case/motivation

It will be more intuitive. At least for in my case I couldn't find until I was told in #37009 (comment) that that button exist.

The "reset password" button itself is not very well documented, at least the google query site:airflow.apache.org "reset password" does not find any reference to it.

Hopefully a more prominent place in the UI will reduce some of the confusion. I also tried to document "reset password" in stackoverflow at least https://stackoverflow.com/a/77886646/90580

Related issues

No response

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[eladm26]

Hi @ecerulm
Would love to take this one as a first issue

[potiuk]

Feel free

[poorvirohidekar]

@potiuk - I would like to try my hand at this. Can you please assign it to me?

[poorvirohidekar]

@bbovenzi - I have been looking into the www/ folder but am unable to find the UI code for this. Can you please point me in the right direction?

[aritra24]

@poorvirohidekar I believe it's part of the Flask app builder library, I believe the change would either have to be in flask app builder itself, or you'd have to override some of the methods and templates used to support edit to have a reset password field. Though I'm not too familiar with this part but on a high level look that's what it looks like.

[poorvirohidekar]

@aritra24 - Yup, I was checking out the same.
@vincbeck - I was actually looking into this edit view implementation. https://github.com/apache/airflow/blob/main/airflow/www/views.py#L3654 and I tried adding a widget

      if not widgets:
           return self.post_edit_redirect()
       else:
           reset_password_button = ResetPasswordView()
           widgets["edit"].append(reset_password_button)
           return self.render_template(
               self.edit_template,
               title=self.edit_title,
               widgets=widgets,
               related_views=self._related_views,
           )

But this doesnt not seem to be adding the resetpassword button. Can you please point me in the right direction here? I am running the breeze start_airflow --dev-mode command to build this. Can you please tell me if this is the right way?

[aritra24]

I believe it might need to be added as an action rather than a new widget. But also I think the edit template might not take actions you'd have to check that.

[vincbeck]

@aritra24 - Yup, I was checking out the same. @vincbeck - I was actually looking into this edit view implementation. https://github.com/apache/airflow/blob/main/airflow/www/views.py#L3654 and I tried adding a widget

      if not widgets:
           return self.post_edit_redirect()
       else:
           reset_password_button = ResetPasswordView()
           widgets["edit"].append(reset_password_button)
           return self.render_template(
               self.edit_template,
               title=self.edit_title,
               widgets=widgets,
               related_views=self._related_views,
           )

But this doesnt not seem to be adding the resetpassword button. Can you please point me in the right direction here? I am running the breeze start_airflow --dev-mode command to build this. Can you please tell me if this is the right way?

This is not the view for edit user information. The view is CustomUserInfoEditView in airflow/providers/fab/auth_manager/views/user_edit.py. I am not entirely sure how to do it, but there must be a way to customize this view using Flask App Builder. Maybe following @aritra24 suggestion?