[AMQ-9239] Jakarta JMS broker #996

mattrpav · 2023-03-30T16:40:42Z

Reviewer Notes:

TODO:

Review jetty.xml pathSpec change

Tests passing:

2023-08-24 Tests passed 0cb5b9b Apache Jenkins Job #80
2023-08-17 Tests passed d4965e7 Apache Jenkins Job #76
2023-06-05 Commit 289731d all modules' tests pass (aka CI green)

Short term (other JIRA):

Modernize activemq-openwire-generator project for JDK 17 and toolchain AMQ-9302

Long term (another JIRA):

Add sniHostCheck and sniRequired transport options

tabish121 · 2023-04-14T16:27:02Z

Just noticed this and wanted to say the TODO about stompjms update to Jakarta seems like something you might want to skip, that project hasn't seen activity since 2016 I think and depends on other equally dead projects like 'hawtio'. I'd maybe just remove any dependency on it at this point.

mattrpav · 2023-04-14T17:45:25Z

Just noticed this and wanted to say the TODO about stompjms update to Jakarta seems like something you might want to skip, that project hasn't seen activity since 2016 I think and depends on other equally dead projects like 'hawtio'. I'd maybe just remove any dependency on it at this point.

@tabish121 good call. I'll update to that effect.

mattrpav · 2023-04-16T22:40:50Z

activemq-http

-[ ] WSSTransportHttpTraceTest needs SSL setup repair -- JDK 17 enforces SNI rules (no 'localhost')

2023-04-20 20:32:04,685 [me-limited test] - WARN  config                         - No Client EndPointIdentificationAlgorithm configured for Client@6ec88514[provider=null,keyStore=null,trustStore=null]
2023-04-20 20:32:04,818 [tp1642679791-46] - WARN  HttpChannel                    - handleException / org.eclipse.jetty.http.BadMessageException: 400: Invalid SNI

Unit test runs:

1. [ERROR] Tests run: 531, Failures: 0, Errors: 129, Skipped: 0
2. [ERROR] Tests run: 531, Failures: 5, Errors: 70, Skipped: 0
3. [ERROR] Tests run: 531, Failures: 5, Errors: 4, Skipped: 0

I could use a set of eyes on the Jetty stopTimeout issue. The vast majority of unit tests are failing due to lifecycle problem w/ Jetty 11 taking too long to shutdown some resources. Setting a breakpoint (and some natural amount of time passing > 10s) and the tests pass. When I set the stopTimeout to 5s (up from current 500ms, the tests fail.

Jetty 11 stopTimeout related classes

./src/main/java/org/apache/activemq/transport/SecureSocketConnectorFactory.java
./src/main/java/org/apache/activemq/transport/WebTransportServerSupport.java
./src/main/java/org/apache/activemq/transport/SocketConnectorFactory.java

ref: https://stackoverflow.com/questions/65443271/set-up-websockets-with-jetty-11

hellokkiyer · 2023-05-23T15:49:36Z

Is the jakarta supported activemq-broker jar going to be released?

mattrpav · 2023-05-23T15:51:55Z

@hellokkiyer yes. Once the work on this PR is completed, Jakarta support for ActiveMQ 5.x broker will be released. Currently, we are planning to target 5.19.0 for Jakarta broker support.

hellokkiyer · 2023-05-23T15:54:02Z

@mattrpav Thanks for the prompt response. Any tentative or approximate date for 5.19 release? It would help us plan our release better. Thanks in advance.

mattrpav · 2023-05-23T15:55:59Z

@hellokkiyer no exact ETA at this point. I suspect a few weeks to 1-2 months max (hopefully?!)

maverickabhi1991 · 2023-05-23T16:44:08Z

@mattrpav Nice to see this PR in running mode. Can we use apache activemq with Spring 6 without this PR as jakarta modules are required in Spring 6.0.0? I have a project with spring version is 5.3.27 and apache active client version is 5.18.1 and it's running fine. As soon as I upgrade the Spring to 6.0.0 it starts giving me "java.lang.IllegalStateException: Cannot convert value of type 'org.apache.activemq.pool.PooledConnectionFactory' to required type 'jakarta.jms.ConnectionFactory' for property 'connectionFactory': no matching editors or conversion strategy found".
Any workaround to this problem?

mattrpav · 2023-05-23T16:49:35Z

@maverickabhi1991 The pooled connection factory has not been ported to jakarta yet. That's part of this change, which moves all of ActiveMQ 5.x to Jakarta. You can use Spring 6 w/ activemq-client-jakarta, but not with a pooled connection factory at the moment.

mattrpav · 2023-05-24T13:57:43Z

Web console queue functions - pause, resume and delete throw exception:

Caused by: jakarta.servlet.ServletException: Request processing failed: java.lang.UnsupportedOperationException: Possible CSRF attack
	at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1019) ~[spring-webmvc-6.0.7.jar:6.0.7]

demidov163 · 2023-06-09T06:06:00Z

Hello, any chance to merge this PR in coming days? Very important functional.

mattrpav · 2023-06-09T13:32:26Z

Hi @demidov163- There are a couple things left to sort out. I'm hoping its in the next 1-2 weeks. Currently, the team is working on 5.17.x and 5.18.x point releases. Thanks!

cshannon · 2023-06-19T22:17:37Z

@mattrpav - I submitted a PR to this branch to fix the http timeout stuff mattrpav#1

ksdevelops · 2023-07-12T08:53:40Z

hi @mattrpav
Any update on the 5.19 release for jakarta broker support?
It's a very important functionality. We are in middle of migrating to JDK17 and Spring 6. The current activemq broker doesn't support jakarta messaging.
Any tentative ETA would be helpful.

narendranss · 2023-07-28T05:22:07Z

Any idea when this change will be available? or is there any other alternative to migrate for jakarta?

prasad5400 · 2023-07-31T07:08:52Z

What is the plan to release this functionality? We need this for your migration to JDK17 and Spring 6.

mattrpav · 2023-07-31T14:28:31Z

@narendranss @prasad5400 reminder-- the 5.18.2 release has support for a Jakarta client, and you can use SB3, Spring 6 and Java 17 with activemq-client-jakarta-5.18.2.jar.

As far as schedule, we are working through the last few issues and dependency clean-ups. I've had a 'green' CI run, so I have not seen any major bugs or issues up to this point.

ksdevelops · 2023-08-01T06:13:43Z

@narendranss @prasad5400 reminder-- the 5.18.2 release has support for a Jakarta client, and you can use SB3, Spring 6 and Java 17 with activemq-client-jakarta-5.18.2.jar.

As far as schedule, we are working through the last few issues and dependency clean-ups. I've had a 'green' CI run, so I have not seen any major bugs or issues up to this point.

hi @mattrpav
Thanks for the update. I know it's difficult to state exact date, but can you mention a tentative date by which we can get this released in 5.19?
It would help us to decide if we can wait for this functionality to be released or to migrate to any other alternative?
Thanks in advance

mattrpav · 2023-08-01T13:30:25Z

@ksdevelops we are targeting September

pom.xml

cshannon · 2023-08-09T20:00:37Z

The ParallelXATransactionTest seems to be failing because you don't have an XA transaction manager being used, the new config you added uses two local JMS transaction managers. You need to replacement for Geronimo/Jencks such as Atomikos or mock something.

Some of the errors I get when running locally:

This stack trace is showing there is no distributed transaction in progress.

org.springframework.jms.UncategorizedJmsException: Uncategorized exception occurred during JMS processing
	at org.springframework.jms.support.JmsUtils.convertJmsAccessException(JmsUtils.java:311)
	at org.springframework.jms.support.JmsAccessor.convertJmsAccessException(JmsAccessor.java:184)
	at org.springframework.jms.core.JmsTemplate.execute(JmsTemplate.java:510)
	at org.springframework.jms.core.JmsTemplate.send(JmsTemplate.java:587)
	at org.apache.activemq.spring.ParallelXATransactionTest$1ProducerThread$1.doInTransactionWithoutResult(ParallelXATransactionTest.java:109)
	at org.springframework.transaction.support.TransactionCallbackWithoutResult.doInTransaction(TransactionCallbackWithoutResult.java:36)
	at org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140)
	at org.apache.activemq.spring.ParallelXATransactionTest$1ProducerThread.run(ParallelXATransactionTest.java:103)
Caused by: jakarta.jms.JMSException: Session's XAResource has not been enlisted in a distributed transaction.
	at org.apache.activemq.ActiveMQXASession.doStartTransaction(ActiveMQXASession.java:101)
	at org.apache.activemq.ActiveMQSession.send(ActiveMQSession.java:1973)
	at org.apache.activemq.ActiveMQMessageProducer.send(ActiveMQMessageProducer.java:329)
	at org.apache.activemq.ActiveMQMessageProducer.send(ActiveMQMessageProducer.java:289)
	at org.apache.activemq.ActiveMQMessageProducer.send(ActiveMQMessageProducer.java:224)
	at org.apache.activemq.ActiveMQMessageProducerSupport.send(ActiveMQMessageProducerSupport.java:270)
	at org.springframework.jms.core.JmsTemplate.doSend(JmsTemplate.java:637)
	at org.springframework.jms.core.JmsTemplate.doSend(JmsTemplate.java:611)
	at org.springframework.jms.core.JmsTemplate.lambda$send$3(JmsTemplate.java:589)
	at org.springframework.jms.core.JmsTemplate.execute(JmsTemplate.java:507)

This stack trace shows that the JmsTransactionManager is calling commit() on the ActiveMQ XA transaction which isn't allowed and that is because the JmsTransactionManager doesn't know how to handle XA.

org.springframework.transaction.TransactionSystemException: Could not commit JMS transaction

	at org.springframework.jms.connection.JmsTransactionManager.doCommit(JmsTransactionManager.java:286)
	at org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:743)
	at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:711)
	at org.springframework.test.context.transaction.TransactionContext.endTransaction(TransactionContext.java:135)
	at org.springframework.test.context.transaction.TransactionalTestExecutionListener.afterTestMethod(TransactionalTestExecutionListener.java:259)
	at org.springframework.test.context.TestContextManager.afterTestMethod(TestContextManager.java:440)
	at org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:94)
	at org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:84)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:252)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:97)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
	at org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:191)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
	at com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:232)
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:55)
Caused by: jakarta.jms.TransactionInProgressException: Cannot commit() inside an XASession
	at org.apache.activemq.ActiveMQXASession.commit(ActiveMQXASession.java:78)
	at org.springframework.jms.connection.JmsTransactionManager.doCommit(JmsTransactionManager.java:280)
	... 27 more

cshannon · 2023-08-09T20:04:18Z

So anyways, you will need to configure a proper JTA/XA transaction manager set up if you want to use ActiveMQXAConnectionFactory. That factory is not going to work with the standard org.springframework.jms.connection.JmsTransactionManager that is currently configured.

mattrpav

1,321 of 1,421 files changed are namespace-only changes

mattrpav · 2023-08-17T18:09:12Z

pom.xml

cshannon

Have you tried running a test release build with all the plugins? For example, I'm getting errors trying to build javadocs so that needs to be fixed.

Also, we should make sure that activemq-openwire-generator works and that is apparently broken with JDK 17. See: https://lists.apache.org/thread/rfjh94otnbx8h1rxs0l7d654zbf436wn

With the new Jetty updates the shutdown is being blocked by any calls to open BlockingQueueTransports that are waiting on queue.poll(). This commit sends a shutdown info packet to unblock the poll() and also increases the timeout to something more reasonable such as 30 seconds.

…ivemq-web changes

cshannon

I went through a lot of custom tests with this and everything is looking good and I didn't find any issues. I think this is good to merge now. There are still some follow up things to fix like OSGi and openwire generation but there is time for that in follow on PRs before 5.19.0 goes out.

nj185073 · 2023-09-27T15:43:04Z

@mattrpav @cshannon Hello there, any idea when these changes will be released?

aeberhardo · 2023-10-09T08:17:43Z

@mattrpav Hi, is there a roadmap when 5.19.x containing this PR will be available? Thanks!

jbonofre · 2023-10-09T09:12:21Z

@aeberhardo it's not 5.19.x but actually the next ActiveMQ release planned is 6.0.0 (including this change and others). The target date for the vote is end of this week/beginning of next week.

hellokkiyer · 2023-10-10T05:23:16Z

hi @jbonofre
I read in ActiveMQ Artemis Page (https://activemq.apache.org/how-does-activemq-compare-to-artemis) that the next activemq 6 would be the Artemis version. So, will the 6.0.0 that you mentioned, be the Artemis?

jbonofre · 2023-10-10T05:25:30Z

No that's not the case anymore (the website should be updated): we discussed on the mailing list to keep on our ActiveMQ versioning.

So ActiveMQ 6.0.0 will be ActiveMQ (not Artemis). I will update the website.

HarikrishnaSelvarangan · 2023-10-25T06:45:27Z

@jbonofre Kindly let us know when we can expect the active mq 6.0.0 which has upgrade to jakarta for PooledConnectionFactory.

jbonofre · 2023-10-25T06:55:58Z

@HarikrishnaSelvarangan as said on the mailing list, it's planned for this week. We have a bunch of releases in preparation. So if the vote goes well, 6.0.0 should be available next week.

HarikrishnaSelvarangan · 2023-11-02T13:36:30Z

Hi @jbonofre, we could see last week 5.18.3 had been published for activemq-pool which doesn't have Jakarta upgrade. Can we expect activemq-pool with Jakarta this week or any tentative date ?

kunal-bhatia · 2023-11-09T15:21:25Z

@jbonofre , any update on release of version 6.0.0 with support of jakarta in activemq broker?

jbonofre · 2023-11-09T15:23:02Z

@kunal-bhatia you can follow the dev mailing list where we provide updates. I plan to submit 6.0.0 to vote before the end of this week. If the vote pass, 6.0.0 will be available next week.

mattrpav self-assigned this Apr 15, 2023

jeanouii mentioned this pull request May 22, 2023

[AMQ-7072] moving to JSON-B API instead of jackson #308

Closed

gemmellr reviewed Aug 8, 2023

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

mattrpav commented Aug 10, 2023

View reviewed changes

mattrpav marked this pull request as ready for review August 17, 2023 18:09

mattrpav mentioned this pull request Aug 18, 2023

Reintroduce support for ActiveMQ spring-projects/spring-boot#35048

Closed

cshannon reviewed Aug 23, 2023

View reviewed changes

pom.xml Show resolved Hide resolved

cshannon requested changes Aug 23, 2023

View reviewed changes

cshannon and others added 16 commits August 24, 2023 09:45

[AMQ-9239] jakarta.jms - activemq-jms-pool, activemq-pool changes

30114aa

[AMQ-9239] jakarta.jms - activemq-kahadb-store changes

976db65

[AMQ-9239] jakarta.jms - activemq-karaf-itest, activemq-osgi changes

a2f83d4

[AMQ-9239] jakarta.jms - activemq-log4j-appender changes

d83d2f5

[AMQ-9239] jakarta.jms - activemq-mqtt changes

64cbba0

[AMQ-9239] jakarta.jms - activemq-runtime-config, activemq-shiro changes

4faad74

[AMQ-9239] jakarta.jms - activemq-ra, activemq-rar changes

5473ea5

[AMQ-9239] jakarta.jms - activemq-spring changes

af07efe

[AMQ-9239] jakarta.jms - activemq-stomp changes

30127d3

[AMQ-9239] jakarta.jms - activemq-tooling chnages

febcd0b

[AMQ-9239] jakarta.jms - activemq-unit-tests changes

65267a9

[AMQ-9239] jakarta.jms - activemq-web-console, activemq-web-demo, act…

90fbd90

…ivemq-web changes

[AMQ-9239] jakarta.jms - assembly changes

e10d457

[AMQ-9239] jakarta.jms - activemq-unit-tests changes

5243a44

Fix several hanging Http transport tests

0cb5b9b

cshannon approved these changes Aug 29, 2023

View reviewed changes

mattrpav merged commit fc13d61 into apache:main Aug 30, 2023

bbortt mentioned this pull request Aug 31, 2023

Draft: migrate to [email protected] citrusframework/citrus-simulator#163

Closed

apache deleted a comment Mar 27, 2024

[AMQ-9239] Jakarta JMS broker #996

[AMQ-9239] Jakarta JMS broker #996

Uh oh!

Conversation

mattrpav commented Mar 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tabish121 commented Apr 14, 2023

Uh oh!

mattrpav commented Apr 14, 2023

Uh oh!

mattrpav commented Apr 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

activemq-http

Unit test runs:

Jetty 11 stopTimeout related classes

Uh oh!

hellokkiyer commented May 23, 2023

Uh oh!

mattrpav commented May 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hellokkiyer commented May 23, 2023

Uh oh!

mattrpav commented May 23, 2023

Uh oh!

maverickabhi1991 commented May 23, 2023

Uh oh!

mattrpav commented May 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattrpav commented May 24, 2023

Uh oh!

demidov163 commented Jun 9, 2023

Uh oh!

mattrpav commented Jun 9, 2023

Uh oh!

cshannon commented Jun 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ksdevelops commented Jul 12, 2023

Uh oh!

narendranss commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prasad5400 commented Jul 31, 2023

Uh oh!

mattrpav commented Jul 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ksdevelops commented Aug 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattrpav commented Aug 1, 2023

Uh oh!

Uh oh!

cshannon commented Aug 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cshannon commented Aug 9, 2023

Uh oh!

mattrpav left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mattrpav commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cshannon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cshannon left a comment

Choose a reason for hiding this comment

Uh oh!

nj185073 commented Sep 27, 2023

Uh oh!

aeberhardo commented Oct 9, 2023

Uh oh!

mattrpav commented Mar 30, 2023 •

edited

Loading

mattrpav commented Apr 16, 2023 •

edited

Loading

mattrpav commented May 23, 2023 •

edited

Loading

mattrpav commented May 23, 2023 •

edited

Loading

cshannon commented Jun 19, 2023 •

edited

Loading

narendranss commented Jul 28, 2023 •

edited

Loading

mattrpav commented Jul 31, 2023 •

edited

Loading

ksdevelops commented Aug 1, 2023 •

edited

Loading

cshannon commented Aug 9, 2023 •

edited

Loading

mattrpav left a comment •

edited

Loading

mattrpav commented Aug 17, 2023 •

edited

Loading

cshannon left a comment •

edited

Loading

hellokkiyer commented Oct 10, 2023 •

edited

Loading