added unit test for TGW code to find servers #5885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TGW had code for finding servers that would break if TServerInstance ever changes its compare to method. Refactored code to make it testable and added unit test that should detect any changes in the compareto method.
DomGarguilo
reviewed
Sep 15, 2025
server/manager/src/test/java/org/apache/accumulo/manager/TabletGroupWatcherTest.java
Outdated
Show resolved
Hide resolved
dlmarion
approved these changes
Sep 16, 2025
DomGarguilo
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TGW had code for finding servers that would break if TServerInstance ever changes its compare to method. Refactored code to make it testable and added unit test that should detect any changes in the compareto method.