fix: include local streaming device in device list popup #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The device pane (Shift+D) was showing empty when users didn't configure a custom client_id, even when using the integrated streaming feature. This was problematic because: - Users couldn't see available devices to transfer playback - When Spotify automatically switched playback to another device (e.g., phone), there was no way to switch back through the UI - The local streaming device was functional but invisible in the device list This commit modifies the GetDevices handler to automatically include the local librespot device when the streaming feature is enabled. The device is only added if not already present in the API response, avoiding duplicates. With this fix, the device list will always show at least the local device when streaming is enabled, allowing users to transfer playback back to their computer even when Spotify switches it elsewhere. Fixes the issue where integrated playback was functional but the device management UI was unusable. Signed-off-by: Gustavo Lima Chaves <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where the local streaming device was not included in the device list popup.