Improve the track page layout #843
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What theme is that btw? |
Author
a slight variation of "dracula": name = "dracula.mathias"
[themes.palette]
background = "#1e1f29"
foreground = "#f8f8f2"
black = "#000000"
red = "#ff5555"
green = "#50fa7b"
yellow = "#f1fa8c"
blue = "#bd93f9"
magenta = "#ffa000" # section-marker
cyan = "#8be9fd"
white = "#bbbbbb"
bright_black = "#555555"
bright_red = "#ff5555"
bright_green = "#50fa7b"
bright_yellow = "#f1fa8c"
bright_blue = "#bd93f9"
bright_magenta = "#ff79c6"
bright_cyan = "#8be9fd"
bright_white = "#ffffff" |
|
Awesome, thanks! |
This commit improves the track page layout in various aspects: * An additional column to carry the play/pause state is added. * The track number column is right aligned. Its maximum width is calculated based upon the number of tracks (before it was hardcoded to '4', assuming rightfully so 9999 tracks is pretty large). The track number column title '#' is now visually stable ontop of the actual track number.
mgumz
force-pushed
the
improve/track-page-layout
branch
from
90f4aef to
dd30fe2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the track page layout in various aspects:
An additional column to carry the play/pause state is added.
The track number column is right aligned. Its maximum width is calculated based upon the number of tracks (before it was hardcoded to '4', assuming rightfully so 9999 tracks is pretty large). The track number column title '#' is now visually stable ontop of the actual track number.