Skip to content

Conversation

@steviez
Copy link
Collaborator

@steviez steviez commented Oct 22, 2025

A couple items are logged, and we can simply use eprintln!() instead.

This is part of a larger initiative to remove solana-logger from the SDK as it seemingly belongs with Agave

@steviez
Copy link
Collaborator Author

steviez commented Oct 22, 2025

Hmm ok, CI failed because of this line:

::solana_logger::setup();

Trying to figure out if we need this or not

Edit: I have updated the PR to remove the use of solana-logger from frozen-abi-macro

@steviez steviez force-pushed the rm_unused_logger_dep branch from 7a6a988 to 2dbbd29 Compare October 22, 2025 20:52
@steviez steviez requested a review from a team as a code owner October 22, 2025 20:52
@steviez steviez changed the title account: Remove unused dependency on solana-logger Remove frozen-abi-macro dependency on solana-logger Oct 22, 2025
@steviez steviez force-pushed the rm_unused_logger_dep branch 2 times, most recently from f14c26c to b1fab5c Compare October 22, 2025 21:01
apfitzge
apfitzge previously approved these changes Oct 22, 2025
Copy link
Contributor

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to print instead of log. logger should 100% be agave-logger not solana-logger

@steviez
Copy link
Collaborator Author

steviez commented Oct 22, 2025

Hmm, I just noticed there are some log invocations in solana-frozen-abi like this one:

info!("updating with: {}", buf.trim_end());

These are basically unprintable now if we do not setup a logger; we could either setup env_logger where solana_logger::setup() was OR update all those to println!() too. Thoughts ?

@steviez steviez requested a review from joncinque October 22, 2025 22:57
@joncinque
Copy link
Collaborator

I'd say go with println! everywhere there was an info!, and eprintln! everywhere there was a warn! or error!. These logs are just used for debugging frozen-abi changes

There are several log!() lines as well as the solana_logger::setup() in
frozen-abi-macro. Adjust the log lines to println!() and eprintln!() to
remove the dependency; these output lines are only in frozen-abi tests
@steviez steviez force-pushed the rm_unused_logger_dep branch from 47a68db to 0c9680e Compare October 23, 2025 03:12
Copy link
Collaborator

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment on the nits bit

@steviez steviez requested review from apfitzge and joncinque October 23, 2025 14:51
Copy link
Collaborator

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@steviez steviez merged commit ec5e1c5 into anza-xyz:master Oct 23, 2025
26 checks passed
@steviez steviez deleted the rm_unused_logger_dep branch October 23, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants