program-error: Deprecate PrintProgramError #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem As part of the breaking change to unite pinocchio's program error with the sdk's program error in anza-xyz#12, we are introducing a new `ToStr` trait that doesn't rely on any particular logging. To go with that, we want to deprecate `PrintProgramError`. #### Summary of changes Before landing the breaking change, let's deprecate `PrintProgramError` properly and add `ToStr` as an alternative for downstream users. Once this lands, we'll do the patch release with the deprecation, then we can finally land anza-xyz#12.
This was referenced Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As part of the breaking change to unite pinocchio's program error with the sdk's program error in #12, we are introducing a new
ToStrtrait that doesn't rely on any particular logging.To go with that, we want to deprecate
PrintProgramError.Summary of changes
Before landing the breaking change, let's deprecate
PrintProgramErrorproperly and addToStras an alternative for downstream users.Once this lands, we'll do the patch release with the deprecation, then we can finally land #12.
cc @kevinheavey