Skip to content

Conversation

@wen-coding
Copy link
Contributor

Problem

The original event_handler tests were reverted because they failed coverage tests on ci machine.

Summary of Changes

  • We can directly call handle_event, but that won't work in the future if we somehow add some code outside handle_event, blindly testing input/output on the event loop is still ideal because it is ignorant of internal implementation
  • When I did revert of 8243 (Revert "votor: ignore event_handler tests (#8243)" agave#8251), I set the timeout to 50ms and the test passed. To be extra careful, I'm setting the timeout to 100ms now, and I'll test it on ci machine for a few days ((Draft) Draft to try test strategy, do not review please. agave#8304) to see that coverage tests keep passing
  • Also reworked a few delay related items to make sure we don't actually wait that long in tests

@wen-coding wen-coding marked this pull request as draft October 1, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant