feat: don't discard BlockComponent::VersionedBlockMarkers
#446
Conversation
ksn6
changed the title
BlockComponent::VersionedBlockMarker'sBlockComponent::VersionedBlockMarkers
|
Any reason not to develop this in the upstream (Agave) repo? |
ksn6
force-pushed
the
get-blockstore-to-store-block-components
branch
from
cdfdd1b to
03dc5a4
Compare
Discussed offline, updating the thread here - prior to developing this in (0) wait for solana-foundation/solana-improvement-documents#337 to pass |
ksn6
force-pushed
the
get-blockstore-to-store-block-components
branch
from
03dc5a4 to
590db03
Compare
| pub fn get_components_in_data_block( | ||
| &self, | ||
| slot: Slot, | ||
| range: Range<u32>, | ||
| slot_meta: Option<&SlotMeta>, | ||
| ) -> Result<Vec<BlockComponent>> { | ||
| self.get_slot_components_in_block(slot, vec![range], slot_meta) | ||
| } |
There was a problem hiding this comment.
does this just wrap range in a vec? Could we just do this inside get_entries_in_data_block?
| .into_iter() | ||
| .filter_map(|component| component.into_entries()) | ||
| .flatten() | ||
| .collect() |
There was a problem hiding this comment.
oof. The double alloc is pain. But I think we already do this upstream
| pub fn get_slot_components( | ||
| &self, | ||
| slot: Slot, | ||
| shred_start_index: u64, | ||
| ) -> Result<Vec<BlockComponent>> { | ||
| self.get_slot_components_with_shred_info(slot, shred_start_index, false) | ||
| .map(|x| x.0) | ||
| } |
There was a problem hiding this comment.
Could probably live without this shim layer as well, but I guess it's fine
|
Will resume this once I have code working that's able to successfully disseminate block markers around. |
3 participants
Problem
To get fast leader handover rolling (#293), we need to send out
ParentReadyUpdatemessages. These are of typeBlockComponent::VersionedBlockMarker, which are currently entirely discarded.Summary of Changes
Vec<Entry>, we turn shreds into aVec<BlockComponent>vectorVec<Entry>andVec<BlockComponent>when necessary