-
Notifications
You must be signed in to change notification settings - Fork 33
feat: catchup to agave, until 2025-08-07 + bank-related modifications
#410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6eda349 to
f3a4089
Compare
agave, until 2025-08-07agave, until 2025-08-07 + bank-related modifications
Is it possible to split into two PRs:
|
* fix test_get_slot_entries_with_shred_count_corruption * fix test_merkle_root_metas_data
As outlined in #7256, we need to get Agave off of crates that depend back on Agave. spl-token-2022 is one of those crates Use spl-token-2022-interface instead. To go with this, we had to also upgrade to confidential-transfer-proof-extract v0.4.0, which requires modifications to some tests. Everything should be very straightforward otherwise, and we get to see some red lines in the lockfile!
After #7291 landed, #7298 didn't mention any conflicts. However, since the first one migrated away from spl-memo, and so did #7298, there was an entry not cleaned up between the two PRs. Remove the unneeded entry for spl-memo in all lockfiles.
* greedy_scheduler: cache Batches This avoids a bunch of allocations/deallocations in the hot path * banking: move Batches to SchedulingCommon * banking: clean up send_batch(es)
* turbine: move standard_broadcast_run to non-overlapping ports * turbine: move benchmark broadcast_shreds_bench to non-overlapping ports
…(#7148) validator: migrate admin_rpc_service
Renaming UPSERT_POPULATE_RECLAIMS to UPSERT_RECLAIM_TEST_DEFAULT
* Renames bpf_account_data_direct_mapping => stricter_abi_and_runtime_constraints. * Adds InvokeContext::account_data_direct_mapping. * Separates stricter_abi_and_runtime_constraints from account_data_direct_mapping. * Rekeys stricter_abi_and_runtime_constraints. * Adjusts test_serialize_parameters_with_many_accounts().
* move cluster_info::Node to separate module * update the use path in other files to refer to the new location
…x tests (#7312) Changing tests to use u64 rather than bool for T during accounts index tests
spl-token dependency replaced with spl-token-interface.
* Remove conformance tests * Remove transaction builder
* clean up the server spawn API * remove pub from functions which do not need to be pub * remove some obviously wrong comments
docs: remove docs/src/operations/validator-initiatives.md
… i64 (#7309) * Changing addref from a boolean to a counter * Removed formatting from assert as it can degrade perf * Remove dead code
* update shred format tests to use merkle shreds * address feedback from Brennan
* Update lib.rs * Update sysvar.rs * Update sigverify_shreds.rs * Update genesis_accounts.rs
* Update read_only_accounts_cache.rs * Update tests.rs * Update memory.rs * Update byte_block.rs
* Change signature of configure * Remove index in callee from InstructionAccount * Remove parameter from constructor * Add comment and constant * Add tests * Update toml file * Sort cargo file * debug_assert against the deduplication map length * Assert maximum accounts
2b1c3bf to
6353196
Compare
Discussed offline - I think we're good to merge everything into this PR given that we're replacing the condvar stuff with a simple sleep. |
NOTE: in addition to catching up, we make the following modifications:
(1) To accommodate anza-xyz/agave@b82d3bb:
root_bank_cache.rsand useSharableBankinstead(2) To accommodate anza-xyz/agave@dc0f51a:
LeaderBankNotifierinblock_creation_loop.rsThese modifications are important to make now rather than later; otherwise, we cannot cherry-pick all commits that get us on track to Agave. It's dangerous to selectively cherry-pick commits; we don't want to risk cherry-picking a later commit that indirectly depends on something we skipped, or else weird bugs may occur.