refactor: introducing votor-messages crate #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could use feedback on |
wen-coding
reviewed
Jul 29, 2025
AshwinSekar
reviewed
Jul 29, 2025
ksn6
force-pushed
the
remove-certificate-rs
branch
from
01a5522 to
3a4f846
Compare
formatting abi updates sort dependencies from_certificate_type -> new CertificateId -> Certificate votor -> votor-messages
ksn6
force-pushed
the
remove-certificate-rs
branch
from
3a4f846 to
c1929d1
Compare
AshwinSekar
reviewed
Jul 30, 2025
AshwinSekar
approved these changes
Jul 30, 2025
wen-coding
reviewed
Jul 30, 2025
| fn receive_new_certificates( | ||
| certificate_receiver: &Receiver<(CertificateId, CertificateMessage)>, | ||
| ) -> Result<Vec<(CertificateId, CertificateMessage)>> { | ||
| certificate_receiver: &Receiver<(Certificate, CertificateMessage)>, |
There was a problem hiding this comment.
Originally we did this because Certificate contains something CertificateId doesn't have. Now you use Certificate, CertificateMessage should have Certificate.
There was a problem hiding this comment.
That said, it's probably easier to just do #299
|
For the future please don't merge PRs before the checks pass |
|
Checks already passed several times (this may not appear because of the rebases I've been making). That's fine though - can wait a bit longer in the future for the final green checks to show up. |
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We'd like to factor out message types employed in votor into a new crate.
Summary of Changes
Perform said refactoring. Addresses #294.