Handle commitment sender disconnect and unify exit code in CertificatePoolService. #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllin
reviewed
Jul 27, 2025
| voting_context, | ||
| )); | ||
| alpenglow_update_commitment_cache( | ||
| let _ = alpenglow_update_commitment_cache( |
There was a problem hiding this comment.
whats the purpose of adding an error if we just ignore it here?
There was a problem hiding this comment.
This function is called from both EventHandler and CertificatePoolService. This PR only handles the error on the CertificatePoolService side, the EventHandler error handling can be done in a future PR maybe? I suppose EventHandler should also exit on disconnect.
bw-solana
approved these changes
Jul 28, 2025
AshwinSekar
approved these changes
Jul 28, 2025
carllin
approved these changes
Jul 28, 2025
wen-coding
added a commit
to wen-coding/alpenglow
that referenced
this pull request
Jul 29, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.