event_handler: unify the completed_block_sender and event_sender #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwinSekar
commented
Jul 20, 2025
| // Leader blocks will not have a block id, broadcast stage will | ||
| // take care of notifying the voting loop | ||
| let _ = completed_block_sender.send(CompletedBlock { | ||
| let _ = votor_event_sender.send(VotorEvent::Block(CompletedBlock { |
There was a problem hiding this comment.
this and broadcast_utils is the actual change on the sender side, rest is the corresponding plumbing
carllin
approved these changes
Jul 23, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We maintain a separate sender for
Blockevents. Instead just use the regular event sender.Having the event sender available to tvu will also let us send
FirstShredevents in the future.Summary of Changes
Remove the
completed_block_sender/receiverand plumb theevent_senderinstead.Fixes #283