-
Notifications
You must be signed in to change notification settings - Fork 29
Add utility to add alpenglow vote program to genesis #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
runtime/src/genesis_utils.rs
Outdated
| solana_program::bpf_loader_upgradeable::get_program_data_address(&address); | ||
|
|
||
| // Generate the data for the program data account | ||
| let upgrade_authority_address = Pubkey::default(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor nit: could use the system program system_program::id() as I've heard that's the convention for these "enshrined" programs
| solana_stake_program::add_genesis_accounts(&mut genesis_config); | ||
|
|
||
| if is_alpenglow { | ||
| // TODO: enable this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's no harm in just always enabling this right? having this random program shouldn't break tower bft?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the .so is not being built without Karthik's PR, so it would panic on trying to find the binaries
Problem
Currently no convenient way to load the alpenglow vote program for local cluster tests
Summary of Changes
Fixes #