Fix some panics #100
Merged
Fix some panics #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wen-coding
reviewed
Mar 20, 2025
| ); | ||
| } | ||
|
|
||
| info!( |
There was a problem hiding this comment.
Do we still need info! on line 2376 if we log here?
There was a problem hiding this comment.
We can exit before this line is hit
core/src/replay_stage.rs
Outdated
| // We are in full alpenglow mode | ||
| let highest_certificate_slot = cert_pool.highest_certificate_slot(); | ||
| if highest_certificate_slot < first_alpenglow_slot.unwrap() { | ||
| // We haven't got a notarization yet for any of the first |
There was a problem hiding this comment.
nit: notarization -> notarization cert
wen-coding
approved these changes
Mar 21, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 1, 2025
bw-solana
pushed a commit
to bw-solana/alpenglow
that referenced
this pull request
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
Remove panicking asserts
Fixes #