fix(WSL): Fix parallelism support for WSL systems with enabled systemd

[yermulnik]

Put an x into the box if that apply:

• This PR introduces breaking change.
• This PR fixes a bug.
• This PR adds new functionality.
• This PR enhances existing functionality.

Description of your changes

Add a version of WSLInterop file that exists in WSL with SystemD enabled.
Ref: Mozilla-Ocho/llamafile#275

Fixes #871

Or should we better use something like grep -qi Microsoft /proc/version (ref: microsoft/WSL#4071) — @MaxymVlasov What do you think? 🤔

[Copilot]

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)

• hooks/_common.sh: Language not supported

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Refactor
  • Improved the system’s environment detection for more accurate recognition of available CPU resources. The enhancement refines how CPU allocations are computed by incorporating additional checks, ensuring that resource determinations remain reliable while preserving current functionality.

Walkthrough

This pull request refines the common::get_cpu_num function in the hooks/_common.sh script. It introduces a local variable wslinterop_path initialized with the path "/proc/sys/fs/binfmt_misc/WSLInterop". The conditional logic has been updated to check for the absence of both wslinterop_path and wslinterop_path-late files to determine the environment type. The functionality for calculating the number of CPU cores based on CPU quota and period remains unchanged, and there are no modifications to public entity declarations.

Changes

File	Change Summary
hooks/_common.sh	Refactored the WSL detection by introducing a new local variable wslinterop_path and updating the condition to check for both WSLInterop and WSLInterop-late.

Sequence Diagram(s)

sequenceDiagram
    participant Caller as System
    participant Function as get_cpu_num
    Caller->>Function: Invoke get_cpu_num
    Function->>Function: Define local variable wslinterop_path with "/proc/sys/fs/binfmt_misc/WSLInterop"
    alt WSL detection check
        Function->>Function: Check if both wslinterop_path and wslinterop_path-late are absent
        Note right of Function: Determines WSL environment correctly
    else Other Environment
        Function->>Function: Proceed with CPU quota/period logic
    end
    Function->>Caller: Return computed CPU count

Loading

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between d3066b2 and 759fcb7.

📒 Files selected for processing (1)

• hooks/_common.sh (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• hooks/_common.sh

---

Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f7717cd and eaf75a3.

📒 Files selected for processing (1)

• hooks/_common.sh (1 hunks)

🧰 Additional context used

🪛 Shellcheck (0.10.0)

hooks/_common.sh

[error] 209-209: Remove spaces around = to assign.

(SC2290)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: 🧪 Tests / pytest@🐍3.9@macos-14
• GitHub Check: 🧪 Tests / pytest@🐍3.9@macos-13
• GitHub Check: 🧪 Tests / pytest@🐍3.13@macos-14
• GitHub Check: 🧪 Tests / pytest@🐍3.13@macos-13
• GitHub Check: 🧪 Tests / pytest@🐍3.12@windows-2025
• GitHub Check: 🧪 Tests / pytest@🐍3.10@windows-2025
• GitHub Check: pre-commit

[MaxymVlasov]

Or should we better use something like grep -qi Microsoft /proc/version

Sounds good to me too. I not sure what is faster or more relaible solution for our case.
And there WSL and WSL2 - they could have different behavior

[yermulnik]

Or should we better use something like grep -qi Microsoft /proc/version

Sounds good to me too. I not sure what is faster or more relaible solution for our case. And there WSL and WSL2 - they could have different behavior

Here's how the Snapd does it: https://github.com/canonical/snapd/blob/master/release/release.go#L176-L190 — so I'm leaning to let it check whether any of these not exist: WSLInterop, WSLInterop-late, and additionally /run/WSL (I'm adding this third file to the bundle now).

[Copilot]

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)

• hooks/_common.sh: Language not supported

[MaxymVlasov]

LGTM, just let's wait confirmation from @raypappa that it works for him

[raypappa]

To follow up here as well as on the original issue. This works great for me. I added some additional information on the original issue.

[antonbabenko]

This PR is included in version 1.98.1 🎉