fix: Allow CommonTokenStream to reset properly #4245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There is a flag in CommonTokenStream that indicates whether EOF has
already been fetched/seen. This was not being reset when a new TokenSource
was given to an existing CommonTokenStream and there was no Reset() function
which was unfortunately not exported and not part of the interface for TokenStream.
- Reset the flag when a new source is provided
- Export the Reset() function so that a TokenStream can be rewound
Signed-off-by: Jim.Idle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Implement Reset in TokenStream interface and fix both it and SetTokenSource
ping: @parrt