Skip to content

Revert "Cpp target: No building tests/samples for external utfcpp" #3149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2021
Merged

Revert "Cpp target: No building tests/samples for external utfcpp" #3149

merged 1 commit into from
Apr 9, 2021

Conversation

mike-lischke
Copy link
Member

@mike-lischke mike-lischke commented Apr 9, 2021 •
edited
Loading

Reverts #3040

This seems to conflict more than expected with previous patches for utfcpp.

@mike-lischke
Copy link
Member Author

@parrt A patch to fix the C++ test builds.

@parrt parrt merged commit 478e464 into antlr:master Apr 9, 2021
@mike-lischke mike-lischke deleted the revert-3040-patch-1 branch April 10, 2021 09:17
@parrt parrt added this to the 4.9.3 milestone Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
target:cpp type:bug
Projects
None yet
Milestone
4.9.3
Development

Successfully merging this pull request may close these issues.
2 participants
@mike-lischke @parrt