Silence Swift compiler warnings in Swift runtime #3026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niw
force-pushed
the
silence_swift_compiler_warnings
branch
from
0ecc0f5 to
a0536d6
Compare
These usage of `var` instead of `let` causes Swift compiler warnings.
niw
force-pushed
the
silence_swift_compiler_warnings
branch
from
a0536d6 to
a38cdb6
Compare
|
will tryy to merge it as part of #3301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
Current Swift runtime contains multiple usage of
varwhich is not necessary and recent Swift compiler emits warning for suchvarusage.For example:
Solution
Since there is no easy way to silence it from compiler option especially when it provided in Swift Package Manager,
Fix these usage of
varinstead ofletcauses Swift compiler warnings.