Fix clang compile error with --stdlib=libc++ #2899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On linux. Most users haven't installed libc++-dev, but ANTLR is passing the "--stdlib=libc++" argument. As a result, this won't compile. Users will see: ``` /tmp/antlr4/runtime/Cpp/runtime/src/antlr4-common.h:8:10: fatal error: 'algorithm' file not found ``` This is caused by the "WITH_LIBCXX" option. It was introduced by: antlr@d46ef90 It causes the option "--stdlib=libc++" to be appended by default. I believe its default value should have been left as "Off". With "off" by default, clang will use its default C++ library, which is always available. The WITH_LIBCXX option is kept, being able to change the C++ library might be useful? BUG=antlr#2898
|
Hi everyone, Could you please take a look? |
ArthurSonzogni
force-pushed
the
bug-2898
branch
from
096b75d to
f68c47a
Compare
mike-lischke
approved these changes
Sep 10, 2020
|
@parrt This is a small C++ build patch and can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On linux. Most users haven't installed libc++-dev, but ANTLR is passing
the "--stdlib=libc++" argument. As a result, this won't compile. Users
will see:
This is caused by the "WITH_LIBCXX" option.
It was introduced by:
d46ef90
It causes the option "--stdlib=libc++" to be appended by default.
I believe its default value should have been left as "Off".
With "off" by default, clang will use its default C++ library, which is
always available.
The WITH_LIBCXX option is kept, being able to change the C++ library
might be useful?
BUG=#2898