Skip to content

Conversation

d-markey
Copy link
Contributor

No description provided.

@ericvergnaud
Copy link
Contributor

Hi,
thanks for this but I'm not sure everyone would want this by default, rather the opposite imho...
Eric

@d-markey
Copy link
Contributor Author

I see the point, maybe setting the attribute at class level is a too general. My use-case is debugging post-parsing code with custom listeners: I just don't want to go through each "XXXContext.Accept()" and "BaseVisitor.VisitXXX()" methods. I can revise my changes for the parser part and apply the DebuggerStepThrough attribute only for "Accept()" methods. Would that seem more legitimate?

@ericvergnaud
Copy link
Contributor

DebuggerNonUserCodeAttribute would be more acceptable

@d-markey d-markey marked this pull request as draft May 31, 2020 21:11
@d-markey d-markey marked this pull request as ready for review May 31, 2020 23:04
@ericvergnaud
Copy link
Contributor

@parrt blessed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants