Skip to content

Conversation

vaibhavaingankar09
Copy link

In ReadUUID byte d[] to be reversed only in case of little endian architecture. In the case of big endian Array.Reverse(d) is not required since the bytes are stored in the order most significant to least significant.

@ericvergnaud
Copy link
Contributor

Out of curiosity, which system is exposing the problematic behaviour?
I'm a bit surprised that this would be the only issue with the deserialiser.

@vaibhavaingankar09
Copy link
Author

ATN deserialiser issue arises on s390x systems, with UUID 59627784-3be5-417a-8960-28a73181ebb9 whereas the expected UUID is 59627784-3be5-417a-b9eb-8131a7286089. If we notice the highlighted section of UUID is the representation of 8 bit byte array which is reversed.

@ericvergnaud
Copy link
Contributor

Thanks
To your knowledge, does this only happen with the c# runtime?

@vaibhavaingankar09
Copy link
Author

Yes, it is specific to c# runtime.

@ericvergnaud
Copy link
Contributor

Thanks
@parrt blessed

@parrt parrt merged commit 106c413 into antlr:master Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants