Add new keyword to return proper InputStreams
#1867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the JS runtime sometimes returns (and mangles) the global `window` object instead of a proper InputStream. This is prevented by using the `new` keyword in all cases.
|
Ahh, yikes. Yes, this looks totally kosher to me. Can you also fix lines 33 and 56? They have the same error. https://github.com/TreeViz/antlr4/blob/5e648f0867720ded8a251c0a5c69b506986e159c/runtime/JavaScript/src/antlr4/CharStreams.js#L33 |
Done! Thanks for taking a look. |
|
LGTM. @parrt, anything we need before merging? |
|
Blessed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the JS runtime
CharStreams.fromStringsometimes returns (and mangles) the globalwindowobject instead of returning a proper InputStream. This is prevented by using thenewkeyword in this and similar helper methods.@bhamiltoncx, please take a look. Perhaps I'm doing something wrong... if so, I'm happy to be mistaken!