CPP target runtime: fixed a memleak

[FloorGoddijn]

No description provided.

[Naios]

Did you check whether this is a possible fix for the leaks reported in #1592 ?

[FloorGoddijn]

Hi Naios, I have looked at your valgrind output, my fix is not fixing your problem, but is an equivalent situation, I will closemy current pull request and fix yours as wel in a new one. Regards, Floro From: Naios [mailto:[email protected]] Sent: Wednesday, April 05, 2017 1:19 PM To: antlr/antlr4 <[email protected]> Cc: Floor Goddijn <[email protected]>; Author <[email protected]> Subject: Re: [antlr/antlr4] CPP target runtime: fixed a memleak (#1813) Did you check whether this is a possible fix for the leaks reported in #1592<#1592> ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#1813 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AV6eIafqCKPsG_6tNIc8RFcfKmNS8gvuks5rs3i0gaJpZM4Mz7yf>.

[FloorGoddijn]

I am closing this one as it turns out there more locations where it leaks in a similar way, and will fix this issue: #1592

[FloorGoddijn]

Sorry was looking at old code, this fix seems indeed to be the fix for #1592 as well

[Naios]

@FloorGoddijn Thanks a lot :-)

[parrt]

@mike-lischke shall I merge?

[mike-lischke]

@parrt Yes, that is a good fix, however I doubt this is completely fixing #1592 (from a quick look at the memcheck log I see that there are other areas affected), but I'm happy to be proved wrong :-)