factor out the creation of error nodes and terminal nodes in the parser #1665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser so that they act like a built-in factory during parse tree construction.
|
will take a look.
… On Feb 16, 2017, at 10:43 AM, Terence Parr ***@***.***> wrote:
The new methods act like a built-in factory during parse tree construction. In the end it is a fairly minor change, but since I moved some methods around in Parser, it looks bigger than it is. All I did was to convert new TerminalNodeImpl and new ErrorNodeImpl code to calls to the factory methods. I also cleaned up ParserRuleContext add child stuff.
@antlr/antlr-targets <https://github.com/orgs/antlr/teams/antlr-targets> should consider updating their targets as it adds flexibility that will be handy in a future PR where I support tree construction that contains hidden text before/after nodes.
You can view, comment on, or merge this pull request online at:
#1665 <#1665>
Commit Summary
factor out the creation of error nodes and terminal nodes in the parser so that they act like a built-in factory during parse tree construction.
File Changes
M runtime/Java/src/org/antlr/v4/runtime/ANTLRErrorStrategy.java <https://github.com/antlr/antlr4/pull/1665/files#diff-0> (7)
M runtime/Java/src/org/antlr/v4/runtime/Parser.java <https://github.com/antlr/antlr4/pull/1665/files#diff-1> (56)
M runtime/Java/src/org/antlr/v4/runtime/ParserInterpreter.java <https://github.com/antlr/antlr4/pull/1665/files#diff-2> (5)
M runtime/Java/src/org/antlr/v4/runtime/ParserRuleContext.java <https://github.com/antlr/antlr4/pull/1665/files#diff-3> (92)
Patch Links:
https://github.com/antlr/antlr4/pull/1665.patch <https://github.com/antlr/antlr4/pull/1665.patch>
https://github.com/antlr/antlr4/pull/1665.diff <https://github.com/antlr/antlr4/pull/1665.diff>
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub <#1665>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGGhx5MAIfJM0w7-Vh_FdMZxFrDFaKqJks5rdJi4gaJpZM4MDZEy>.
|
|
@parrt Can you create issues to track this work for the targets? Not able to work on it at the moment. |
This was referenced Feb 17, 2017
Open
|
I updated this branch with a continue PR. #1674 |
hanjoes
added a commit
to hanjoes/antlr4
that referenced
this pull request
Feb 25, 2017
…tlr#899 was not addressed in Swift target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new methods act like a built-in factory during parse tree construction. In the end it is a fairly minor change, but since I moved some methods around in Parser, it looks bigger than it is. All I did was to convert
new TerminalNodeImplandnew ErrorNodeImplcode to calls to the factory methods. I also cleaned up ParserRuleContext add child stuff.@antlr/antlr-targets should consider updating their targets as it adds flexibility that will be handy in a future PR where I support tree construction that contains hidden text before/after nodes.