[Python3] Large import time cost paid for inline unittests

[rmcgregor1990]

Hey,

The python3 antlr runtime spend a large proportion of its import load time importing unittest.
This can profiled with pythons newish -X importtime option.
importtime.txt

My on system it takes ~150ms to import antlr4 and ~100ms of that time is spent importing unittest.
This seems to be like quite a high time cost to pay just the keep the tests inline with the source.

My current project involing creating a python command line tool, which utilises antlr, and I would ideally like to keep the startup time as low as possible.

Would you consider moving the unitests out of the source tree?

Cheers,
Rob

[ericvergnaud]

Hi,
sure please submit a PR

[rmcgregor1990]

Upon further investigation it appears the tests defined within the src tree files are not even run as part of you're test suite.
The only tests run are defined in TestTokenStreamRewriter.py in the test tree.

I'll put together a PR.

[ericvergnaud]

Thanks

…

Le 15 sept. 2020 à 18:18, Rob McGregor ***@***.***> a écrit : PR: #2911 <#2911> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2909 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZNQJDMKX4C535EX3XWSQDSF45PXANCNFSM4RK64VGQ>.

[ericvergnaud]

Are you already in the contributors list? If not, you need to add yourself as part of this PR Eric

…

Le 15 sept. 2020 à 18:18, Rob McGregor ***@***.***> a écrit : PR: #2911 <#2911> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2909 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZNQJDMKX4C535EX3XWSQDSF45PXANCNFSM4RK64VGQ>.