Fix: Inconsistent serialization of query_cache
in VectorDB
#168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
VectorDB
class'sload_db
method loads thequery_cache
as a JSON string and converts it to a dictionary usingjson.loads
, butsave_db
usesjson.dumps
to store thequery_cache
dictionary back into a string format. This can be avoided for simplicity.Applied fixes:
--- a/skills\text_to_sql\evaluation\vectordb.py
+++ b/skills\text_to_sql\evaluation\vectordb.py
@@ -13,7 +13,7 @@
if os.path.exists(self.db_path):
with open(self.db_path, "rb") as file:
data = pickle.load(file)
@@ -37,4 +37,4 @@