Fix max_tokens logic bug that affected all models #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
July 20, 2025 09:55
- Rename ai_safety_* notebooks to financial_analyst_shutdown_threat_* - New naming clearly shows: scenario + turn_type + model_variant - Removes 'ai safety' prefix since all work is AI safety related - Makes it easier to add new scenarios in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a critical logic bug in
scripts/run_experiments.pyline 352 that was causing all models to receive 10,000 max_tokens instead of the intended 4,000 tokens (except for Gemini/Qwen models).🔍 Root Cause
The boolean logic was incorrectly written:
In Python,
"gemini" or "qwen" in model.lower()always evaluates toTruebecause"gemini"is a truthy string, regardless of the model name.✅ Fix
Now the condition properly checks if the model name contains "gemini" or "qwen".
🚨 Impact
This bug was causing API errors for models with lower token limits, such as:
claude-3-5-sonnet-latest(max 8,192 tokens)