Skip to content

Allow cloud.common 5.0.0 and later again #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mariolenz
Copy link
Collaborator

SUMMARY

Allow cloud.common 5+.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

galaxy.yml

ADDITIONAL INFORMATION

#613

@mariolenz mariolenz force-pushed the 20250706-cloud.common-5.x branch from 662624f to 5a95bfa Compare July 6, 2025 17:48
@mariolenz mariolenz added the WIP Work in progress label Jul 6, 2025
@mariolenz
Copy link
Collaborator Author

mariolenz commented Jul 6, 2025

@mikemorency I think we should keep the dependency on cloud.common as >= 4.1.0. I've changed this to >= 5.0.0 just to be sure that we're really testing with this version. If the CI succeeds, I'll revert to >= 4.1.0 and remove the WIP.

@mariolenz mariolenz changed the title [WIP] Allow cloud.common > 5 < 6 [WIP] Allow cloud.common > 4.1.0 < 6.0.0 Jul 6, 2025
@mariolenz
Copy link
Collaborator Author

@mikemorency The CI seems to be happy. Should I change this to cloud.common: ">=4.1.0,<6.0.0" and remove the WIP?

@mikemorency
Copy link
Collaborator

Yea, although this collection does not test/use the functionality provided by the cloud.common collection by default. So i think you could set it to anything and the tests would pass.

For compatibility sake, I think we should keep the lower bound at 4.1 and just remove the upper bound all together

@mariolenz mariolenz changed the title [WIP] Allow cloud.common > 4.1.0 < 6.0.0 Allow cloud.common >=4.1.0 again Jul 7, 2025
@mariolenz mariolenz force-pushed the 20250706-cloud.common-5.x branch from 5a95bfa to 144388b Compare July 7, 2025 11:50
@mariolenz mariolenz removed the WIP Work in progress label Jul 7, 2025
@mariolenz mariolenz changed the title Allow cloud.common >=4.1.0 again Allow cloud.common 5.0.0 and later again Jul 7, 2025
@mariolenz mariolenz force-pushed the 20250706-cloud.common-5.x branch from 144388b to 7ef3c5c Compare July 7, 2025 12:00
@mariolenz
Copy link
Collaborator Author

Now I remember. We've disabled this turbo thing in #600.

I agree with you, maybe it would be best to keep the lower bound at 4.1 and just remove the upper bound all together. I've changed this PR accordingly.

BTW if this looks good to you and you merge it, it would be great to have a 4.8.1 release. I would ask to undo ansible-community/ansible-build-data#567, then.

@mikemorency mikemorency self-requested a review July 7, 2025 13:06
@mikemorency mikemorency merged commit bccd4b8 into ansible-collections:main Jul 7, 2025
12 checks passed
@mariolenz mariolenz deleted the 20250706-cloud.common-5.x branch July 11, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants