update tests to use 2.19

.github/workflows/sanity-tests.yaml

@@ -79,6 +79,7 @@ jobs:
           - stable-2.16
           - stable-2.17
           - stable-2.18
+          - stable-2.19
           - devel
           # - milestone
     runs-on: ubuntu-latest

changelogs/fragments/609-test-with-219.yml

@@ -0,0 +1,4 @@
+---
+trivial:
+  - run integration tests with ansible-core 2.19.0b5
+    (https://github.com/ansible-collections/vmware.vmware_rest/issues/593)

tests/integration/requirements.txt

@@ -1,4 +1,4 @@
-ansible-core
+ansible-core==2.19.0b5
 
 # required for vmware.vmware
 requests

tests/integration/targets/vmware_rest_library_and_ovf_clone/tasks/main.yml

@@ -112,7 +112,7 @@
       register: ovf_item
     - assert:
         that:
-          - ovf_item is changed
+          - ovf_item is ansible.builtin.changed
 
     - name: _Export again the VM as an OVF on the library
       vmware.vmware_rest.vcenter_ovf_libraryitem:
@@ -130,8 +130,8 @@
       register: _result
     - assert:
         that:
-          - not(_result is changed)
-          - _result.id
+          - not(_result is ansible.builtin.changed)
+          - _result.id is defined and _result.id != ''
 
     - name: Get the list of items of the NFS library
       vmware.vmware.content_library_item_info:
@@ -354,6 +354,7 @@
       vmware.vmware_rest.content_subscribedlibrary:
         library_id: "{{ sub_lib.id }}"
         state: absent
+      when: sub_lib.id is defined
 
     - name: Delete test VM
       vmware.vmware_rest.vcenter_vm:

tests/integration/targets/vmware_rest_vcenter_vm_clone_on_library/tasks/main.yml

@@ -67,7 +67,7 @@
     - name: Verify VM template added to the library
       ansible.builtin.assert:
         that:
-          - nfs_lib_item is changed
+          - nfs_lib_item is ansible.builtin.changed
 
     - name: _Create the same template again
       vmware.vmware_rest.vcenter_vmtemplate_libraryitems:
@@ -83,7 +83,7 @@
     - name: Verify no VM template added to the library
       ansible.builtin.assert:
         that:
-          - not (_result is changed)
+          - not (_result is ansible.builtin.changed)
 
     - name: Get the list of items of the NFS library
       vmware.vmware.content_library_item_info:

tests/integration/targets/vmware_rest_vcenter_vm_cloning/tasks/main.yml

@@ -54,7 +54,7 @@
     - name: Verify an instant clone of VM is created
       ansible.builtin.assert:
         that:
-          - vm_instant_clone is changed
+          - vm_instant_clone is ansible.builtin.changed
           - vm_instant_clone.value.name == vm2_name
 
     - name: Create a clone of VM
@@ -71,7 +71,7 @@
     - name: Verify a clone of VM is created
       ansible.builtin.assert:
         that:
-          - clone_vm is changed
+          - clone_vm is ansible.builtin.changed
           - clone_vm.value.name == vm3_name
 
   always:

tests/integration/targets/vmware_rest_vcenter_vm_guest_filesystem_directories/tasks/main.yml

@@ -51,7 +51,7 @@
     - name: Verify changed true
       ansible.builtin.assert:
         that:
-          - vm_dir_info.changed
+          - vm_dir_info is ansible.builtin.changed
 
     - name: Create directory with name duplication in /tmp
       vmware.vmware_rest.vcenter_vm_guest_filesystem_directories:
@@ -72,7 +72,7 @@
     - name: Verify no changes
       ansible.builtin.assert:
         that:
-          - not vm_dir_info.changed
+          - vm_dir_info is not ansible.builtin.changed
           - vm_dir_info.value.error_type == "ALREADY_EXISTS"
 
     - name: Move directory in /tmp
@@ -96,7 +96,7 @@
     - name: Verify changed true
       ansible.builtin.assert:
         that:
-          - vm_dir_info.changed
+          - vm_dir_info is ansible.builtin.changed
 
     - name: Create a directory in /tmp
       vmware.vmware_rest.vcenter_vm_guest_filesystem_directories:
@@ -117,7 +117,7 @@
     - name: Verify changed true
       ansible.builtin.assert:
         that:
-          - vm_dir_info.changed
+          - vm_dir_info is ansible.builtin.changed
 
     - name: Create a temporary directory in /tmp
       vmware.vmware_rest.vcenter_vm_guest_filesystem_directories:
@@ -139,8 +139,8 @@
     - name: Verify changed true
       ansible.builtin.assert:
         that:
-          - vm_dir_info_temp.changed
-          - vm_dir_info_temp.value
+          - vm_dir_info_temp is ansible.builtin.changed
+          - vm_dir_info_temp.value is defined and vm_dir_info_temp.value != ''
 
     - name: Delete directories in /tmp
       vmware.vmware_rest.vcenter_vm_guest_filesystem_directories:

tests/integration/targets/vmware_rest_vcenter_vm_scenario/tasks/create_vm.yml

@@ -22,7 +22,7 @@
 - name: Verify VM creation
   ansible.builtin.assert:
     that:
-      - test_vm is changed
+      - test_vm is ansible.builtin.changed
       - test_vm.value.identity.name == test_vm_name
 
 - name: _Create a VM (again)
@@ -43,7 +43,7 @@
 - name: Verify no VM created second time
   ansible.builtin.assert:
     that:
-      - not(result is changed)
+      - not(result is ansible.builtin.changed)
 
 - name: Search VM with an invalid filter
   vmware.vmware_rest.vcenter_vm_info:

tests/integration/targets/vmware_rest_vcenter_vm_scenario/tasks/vm_hardware.yml

@@ -3,7 +3,7 @@
   vmware.vmware_rest.vcenter_vm_hardware:
     upgrade_policy: AFTER_CLEAN_SHUTDOWN
     upgrade_version: VMX_21
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
   register: _result
 
 - name: Print debug info
@@ -13,13 +13,13 @@
 - name: Verify VM hardware version was chenged
   ansible.builtin.assert:
     that:
-      - _result is changed
+      - _result is ansible.builtin.changed
 
 - name: _Upgrade the VM hardware version (again)
   vmware.vmware_rest.vcenter_vm_hardware:
     upgrade_policy: AFTER_CLEAN_SHUTDOWN
     upgrade_version: VMX_21
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
   register: _result
 
 - name: Print debug info
@@ -29,6 +29,6 @@
 - name: Verify VM hardware version
   ansible.builtin.assert:
     that:
-      - not(_result is changed)
+      - not(_result is ansible.builtin.changed)
       - _result.value.upgrade_status == "PENDING"
       - _result.value.upgrade_version == "VMX_21"

tests/integration/targets/vmware_rest_vcenter_vm_scenario/tasks/vm_hardware_adapter.yml

@@ -1,7 +1,7 @@
 ---
 - name: Create a SATA adapter at PCI slot 34
   vmware.vmware_rest.vcenter_vm_hardware_adapter_sata:
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
     pci_slot_number: 34
   register: _sata_adapter_result_1
 
@@ -12,27 +12,27 @@
 - name: Verify SATA adapter creation
   ansible.builtin.assert:
     that:
-      - _sata_adapter_result_1 is changed
+      - _sata_adapter_result_1 is ansible.builtin.changed
       - _sata_adapter_result_1.value.pci_slot_number == 34
       - '"SATA" in _sata_adapter_result_1.value.label'
 
 - name: _Create a SATA adapter at PCI slot 34 (again)
   vmware.vmware_rest.vcenter_vm_hardware_adapter_sata:
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
     pci_slot_number: 34
   register: _sata_adapter_result_2
 
 - name: Ensure the second call was idempotent
   ansible.builtin.assert:
     that:
-      - _sata_adapter_result_2 is not changed
+      - _sata_adapter_result_2 is not ansible.builtin.changed
       - _sata_adapter_result_1.value.pci_slot_number == _sata_adapter_result_2.value.pci_slot_number
       - _sata_adapter_result_1.id == _sata_adapter_result_2.id
 
 - name: Get information about a specific controller
   vmware.vmware_rest.vcenter_vm_hardware_adapter_sata_info:
-    vm: '{{ test_vm_id }}'
-    adapter: '{{ _sata_adapter_result_1.id }}'
+    vm: "{{ test_vm_id }}"
+    adapter: "{{ _sata_adapter_result_1.id }}"
   register: adapter_sata_info
 
 - name: Print debug info
@@ -46,7 +46,7 @@
 
 - name: List the controller
   vmware.vmware_rest.vcenter_vm_hardware_adapter_sata_info:
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
   register: adapters_info
 
 - name: Verify SATA adapter is in a list of controllers
@@ -56,43 +56,43 @@
 
 - name: List the SCSI adapter of a given VM
   vmware.vmware_rest.vcenter_vm_hardware_adapter_scsi_info:
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
   register: _result
 
 - name: Verify list the SCSI adapter of a given VM found
   ansible.builtin.assert:
     that:
-      - _result is not failed 
+      - _result is not failed
 
 - name: Create a SCSI adapter at PCI slot 35
   vmware.vmware_rest.vcenter_vm_hardware_adapter_scsi:
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
     pci_slot_number: 35
   register: _scsi_adapter_result_1
 
 - name: _Create a SCSI adapter at PCI slot 35 (again)
   vmware.vmware_rest.vcenter_vm_hardware_adapter_scsi:
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
     pci_slot_number: 35
   register: _scsi_adapter_result_2
 
 - name: Ensure the second call was idempotent
   ansible.builtin.assert:
     that:
-      - _scsi_adapter_result_2 is not changed
+      - _scsi_adapter_result_2 is not ansible.builtin.changed
       - _scsi_adapter_result_1.value.pci_slot_number == _scsi_adapter_result_2.value.pci_slot_number
       - _scsi_adapter_result_1.id == _scsi_adapter_result_2.id
 
 - name: Drop the SCSI controller
   vmware.vmware_rest.vcenter_vm_hardware_adapter_scsi:
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
     pci_slot_number: 35
     state: absent
   register: _result
 
 - name: Get list of SCSI adapters
   vmware.vmware_rest.vcenter_vm_hardware_adapter_scsi_info:
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
   register: _result
 
 - name: Verify SCSI adapter droped

tests/integration/targets/vmware_rest_vcenter_vm_scenario/tasks/vm_hardware_boot.yml

@@ -1,6 +1,6 @@
 - name: Retrieve the boot information from the VM
   vmware.vmware_rest.vcenter_vm_hardware_boot_info:
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
   register: hardware_boot_info
 
 - name: Print debug info
@@ -9,7 +9,7 @@
 
 - name: Change a VM boot parameters
   vmware.vmware_rest.vcenter_vm_hardware_boot:
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
     type: EFI
     efi_legacy_boot: true
   register: _result
@@ -21,11 +21,11 @@
 - name: Verify boot device parameters were applied
   ansible.builtin.assert:
     that:
-      - _result is changed
+      - _result is ansible.builtin.changed
 
 - name: _Change a VM boot parameters (again)
   vmware.vmware_rest.vcenter_vm_hardware_boot:
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
     efi_legacy_boot: true
     type: EFI
   register: _result
@@ -37,11 +37,11 @@
 - name: Verify boot device parameters weren't applied
   ansible.builtin.assert:
     that:
-      - not(_result is changed)
+      - not(_result is ansible.builtin.changed)
 
 - name: Get information about the boot device
   vmware.vmware_rest.vcenter_vm_hardware_boot_device_info:
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
   register: _result
 
 - name: Print debug info
@@ -50,7 +50,7 @@
 
 - name: Restore a VM boot parameters
   vmware.vmware_rest.vcenter_vm_hardware_boot:
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
     type: EFI
     efi_legacy_boot: false
   register: _result

tests/integration/targets/vmware_rest_vcenter_vm_scenario/tasks/vm_hardware_cdrom.yml

@@ -1,7 +1,7 @@
 ---
 - name: Attach an ISO image to a guest VM
   vmware.vmware_rest.vcenter_vm_hardware_cdrom:
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
     type: SATA
     sata:
       bus: 0
@@ -19,13 +19,13 @@
 - name: Verify ISO image attached
   ansible.builtin.assert:
     that:
-      - _cdrom_info is changed
+      - _cdrom_info is ansible.builtin.changed
       - _cdrom_info.value.backing.iso_file == "{{ rhel_9_3_iso_path }}"
       - _cdrom_info.value.type == "SATA"
 
 - name: Attach an ISO image to a guest VM (again)
   vmware.vmware_rest.vcenter_vm_hardware_cdrom:
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
     type: SATA
     sata:
       bus: 0
@@ -38,11 +38,11 @@
 
 - name: Ensure idempotency
   ansible.builtin.assert:
-    that: _result is not changed
+    that: _result is not ansible.builtin.changed
 
 - name: List the cdrom devices on the guest
   vmware.vmware_rest.vcenter_vm_hardware_cdrom_info:
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
   register: _cdrom_list
 
 - name: Print debug info
@@ -56,7 +56,7 @@
 
 - name: Set a boot device
   vmware.vmware_rest.vcenter_vm_hardware_boot_device:
-    vm: '{{ test_vm_id }}'
+    vm: "{{ test_vm_id }}"
     devices:
       - type: "CDROM"
   register: _result
@@ -68,4 +68,4 @@
 - name: Verify boot device was set
   ansible.builtin.assert:
     that:
-      - _result is changed
+      - _result is ansible.builtin.changed