Skip to content

update tests to use 2.19 #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2025
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/sanity-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ jobs:
- stable-2.16
- stable-2.17
- stable-2.18
- stable-2.19
- devel
# - milestone
runs-on: ubuntu-latest
Expand Down
4 changes: 4 additions & 0 deletions changelogs/fragments/609-test-with-219.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
trivial:
- run integration tests with ansible-core 2.19.0b5
(https://github.com/ansible-collections/vmware.vmware_rest/issues/593)
2 changes: 1 addition & 1 deletion tests/integration/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ansible-core
ansible-core==2.19.0b5

# required for vmware.vmware
requests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
- assert:
that:
- not(_result is changed)
- _result.id
- _result.id is defined and _result.id != ''

- name: Get the list of items of the NFS library
vmware.vmware.content_library_item_info:
Expand Down Expand Up @@ -354,6 +354,7 @@
vmware.vmware_rest.content_subscribedlibrary:
library_id: "{{ sub_lib.id }}"
state: absent
when: sub_lib.id is defined

- name: Delete test VM
vmware.vmware_rest.vcenter_vm:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
- name: Verify changed true
ansible.builtin.assert:
that:
- vm_dir_info.changed
- vm_dir_info is changed

- name: Create directory with name duplication in /tmp
vmware.vmware_rest.vcenter_vm_guest_filesystem_directories:
Expand All @@ -72,7 +72,7 @@
- name: Verify no changes
ansible.builtin.assert:
that:
- not vm_dir_info.changed
- vm_dir_info is not changed
- vm_dir_info.value.error_type == "ALREADY_EXISTS"

- name: Move directory in /tmp
Expand All @@ -96,7 +96,7 @@
- name: Verify changed true
ansible.builtin.assert:
that:
- vm_dir_info.changed
- vm_dir_info is changed

- name: Create a directory in /tmp
vmware.vmware_rest.vcenter_vm_guest_filesystem_directories:
Expand All @@ -117,7 +117,7 @@
- name: Verify changed true
ansible.builtin.assert:
that:
- vm_dir_info.changed
- vm_dir_info is changed

- name: Create a temporary directory in /tmp
vmware.vmware_rest.vcenter_vm_guest_filesystem_directories:
Expand All @@ -139,8 +139,8 @@
- name: Verify changed true
ansible.builtin.assert:
that:
- vm_dir_info_temp.changed
- vm_dir_info_temp.value
- vm_dir_info_temp is changed
- vm_dir_info_temp.value is defined and vm_dir_info_temp.value != ''

- name: Delete directories in /tmp
vmware.vmware_rest.vcenter_vm_guest_filesystem_directories:
Expand Down
2 changes: 2 additions & 0 deletions tests/sanity/ignore-2.19.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
plugins/modules/vcenter_vm_guest_customization.py pep8!skip
plugins/modules/appliance_infraprofile_configs.py pep8!skip