Feature/deprecate lookups #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the docs test fails because the moid_from_path lookup plugin isn't part of a release yet. But I'm not 100% sure there. I don't understand why the integration tests fail... could this be something temporarily? |
|
I think it is a temporary thing. I feel like Ive seen the error before. Im going to wait until the vmware.vmware release is available before looking much harder |
|
Looks like the test failures were temporary. I had to add a module link to the doc builder GHA, but now that is happy too |
p3ck
approved these changes
Jun 12, 2025
mariolenz
reviewed
Jun 12, 2025
Co-authored-by: Mario Lenz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This deprecates the lookup plugins in favor of vmware.vmware.moid_from_path, since the lookup plugins in this repo will not work with ansible-core 2.19 and above
ISSUE TYPE
COMPONENT NAME
vmware.vmware_rest.*_moid