Skip to content

Update the list of supported connectors #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update the list of supported connectors #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6df499
check for minimum supported connectors
ziegenberg Jun 1, 2021
d510eeb
add changelog fragement
ziegenberg Jun 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/178-update-list-of-supported-connectors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- mysql modules - Update the list of supported connectors and check for minimum required version (https://github.com/ansible-collections/community.mysql/pull/178).
12 changes: 11 additions & 1 deletion plugins/module_utils/mysql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
except ImportError:
mysql_driver = None

mysql_driver_fail_msg = 'The PyMySQL (Python 2.7 and Python 3.X) or MySQL-python (Python 2.X) module is required.'
mysql_driver_fail_msg = 'The PyMySQL >= v0.7.10 (Python 2.7 and Python 3.X) or MySQLdb >= v1.2.5 (Python 2.X) python module is required.'


def parse_from_mysql_config_file(cnf):
Expand All @@ -44,6 +44,16 @@ def parse_from_mysql_config_file(cnf):
def mysql_connect(module, login_user=None, login_password=None, config_file='', ssl_cert=None,
ssl_key=None, ssl_ca=None, db=None, cursor_class=None, connect_timeout=30,
autocommit=False, config_overrides_defaults=False, check_hostname=None):

if mysql_driver.__name__ == "pymysql":
version_tuple = (n for n in mysql_driver.__version__.split('.') if n != 'None')
if reduce(lambda x, y: int(x) * 100 + int(y), version_tuple) < 710:
module.fail_json(msg='PyMySQL >= v0.7.10 is required to use these MySQL modules')
else:
version_tuple = (n for n in mysql_driver.__version__.split('.') if n != 'None')
if reduce(lambda x, y: int(x) * 100 + int(y), version_tuple) < 10205:
module.fail_json(msg='MySQLdb >= v1.2.5 is required to use these MySQL modules')

config = {}

if config_file and os.path.exists(config_file):
Expand Down