-
Notifications
You must be signed in to change notification settings - Fork 347
Fix warning on graph inventory #2002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Fix warning on graph inventory #2002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update.
|
It is interesting to me that they don't mention any delay in their docs... |
|
@p3ck yeah that was also a complaint of mine in my support cases, but MSFT does not seem to care. You can find hints about the 30 hours limit in some other docs though: https://learn.microsoft.com/en-us/azure/network-watcher/network-insights-topology :) |
| Microsoft also makes no guarantees that the information contained is accurate. It happens that | ||
| attributes (such as the PowerState) or entire VMs simply have an incorrect state, disappear and/or | ||
| reappear in different queries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reference to support this part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you have access to support requests you can check 2406170050002212 -- but no, from my opinion that's not properly documented in the public graph docs, same as the potential 30 hour lag, I've complained about that, but it's nothing MSFT wants to fix apparently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope at least you can put some reference about how ARG works and why it can cause these issues, to make the material more sensible.. Otherwise, I don't think anyone will use this inventory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that's the point I am making, the graph service is not usable for an inventory if you have the expectation that your inventory shows accurate & live data :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yet we have a customer who is using it for inventory. And so far my automated tests have not shown any issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess would be they are not sensitive enough to change. For example the stuff with the powerstate="" in Graph I only noticed because some VMs where not updated in their maintenance windows, but only super rarely. I started to export my inventory to git after each sync in order to see changes, that's when I caught up to the general problems. Sometimes a VM would be in it, sometimes it would not be in it, sometimes a Powerstate was "" instead of the actual powerstate. According to MSFT this is all "by design". If that kind of inventory is okay for a customer they can feel free to use it. But it needs to be with a big warning sign because it's not what an actual inventory should be, which is live & accurate information -- or an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If ARG is behaving inproperly and MSFT claimed it was by design, then in what scenario is ARG supposed to be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@magodo that's actually the same question I posed to MSFT and they failed to come up with an answer :) I am guessing it shall be used to situations where neither accuracy/completeness nor time is an immediate factor. The only answer I came up in my head: statistics over your whole environment when you have thousands of machines and it's not important if there is one or more in the results or if one is powered on or simply "" :D . But at least in my ansible world that's not an option, there are important tasks running that rely on the accuracy of the information.
SUMMARY
I have fixed the warning, it's 30 hours not 30 minutes and also added a sentence about the accuracy expectations of Graph.
ISSUE TYPE
COMPONENT NAME
plugins/inventory/azure_kql.py