fix(lsp): Add crash detection and exponential backoff retry #9142
+79
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an LSP process crashes or exits unexpectedly, the client remains in s.clients array forever, causing memory leaks and preventing reconnection attempts. Changes: - Add exit event listener on LSP process handle - Remove dead client from s.clients array on exit - Mark server as broken for retry mechanism - Log crash with exit code and signal - Publish update event for state sync
Instead of permanently marking LSP servers as broken, use exponential backoff to retry them. This allows recovery from transient failures like resource exhaustion or temporary network issues. Changes: - Convert broken from Set<string> to Map with failTime and attemptCount - Add isBrokenWithBackoff() to calculate retry delay using SessionRetry.delay() - Clear broken state on successful connection - Track attempt count across retries for proper backoff
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Inline the backoff constants and calculation directly in the LSP module to avoid a circular dependency chain: lsp/index.ts -> session/retry.ts -> session/message-v2.ts -> lsp/index.ts This was causing LSP.Range to be undefined when message-v2.ts tried to reference it, breaking all tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add exponential backoff retry logic for LSP servers that crash or fail to spawn, preventing permanent disabling of LSP functionality.
Fixes #9153
Problem
When an LSP server fails to spawn or crashes, it gets added to a
brokenset and is never retried during the session. This means if an LSP server temporarily fails (e.g., due to resource constraints), the user loses LSP features for the entire session.Solution
Replace the simple
broken: Set<string>with aMapthat tracks:failTime: When the failure occurredattemptCount: Number of consecutive failuresUse exponential backoff (2s, 4s, 8s, ... up to 30s max) to retry failed servers instead of permanently disabling them.
Changes
packages/opencode/src/lsp/index.ts:brokenfromSet<string>toMap<string, {failTime, attemptCount}>isBrokenWithBackoff()function with exponential backoff calculationTesting
bun turbo typecheck)Note: Manual LSP crash testing (killing LSP server and verifying retry) was not performed.