feat(session): bi-directional cursor-based pagination (#6548) #8535
+1,229
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate FoundPR #6656: "session: paginate message loading"
This is not a duplicate in the traditional sense—it's a more complete implementation that builds upon and replaces the earlier approach. |
CasualDeveloper
changed the title
Contributor
Author
|
@rekram1-node hi Aiden, would appreciate your feedback on how I implemented pagination, per your suggestion! :) |
Contributor
|
Glad I could help kickstart this, I have been a little busy to continue my OSS journey right now. I haven't personally looked through the code in depth (just did a skim) but 1k line changes seems like a lot for one PR (might be better to split it if you can) but once again maybe the code is super clean and simple -- I just haven't sifted through deeply lol. Great work & good luck closing this! |
CasualDeveloper
force-pushed
the
feat/6548-message-pagination
branch
6 times, most recently
from
4f57718 to
afe9c53
Compare
CasualDeveloper
force-pushed
the
feat/6548-message-pagination
branch
3 times, most recently
from
4bd8bf6 to
34eea60
Compare
CasualDeveloper
added a commit
to CasualDeveloper/opencode
that referenced
this pull request
Jan 15, 2026
Adds session_list_limit config option to limit sessions displayed in the session list dialog (default: 150). Limit only applies when not searching; search uses server-side limit of 30. Remove message_limit as it conflicts with cursor-based pagination (anomalyco#8535) and is now redundant.
This was referenced Jan 15, 2026
Open
ryanwyler
added a commit
to gignit/opencode
that referenced
this pull request
Jan 15, 2026
Phase 4-6: Complete auto-scroll implementation - Add KV signal for runtime toggle (persists across sessions) - Add historyConfig memo with default values - Implement loadOlder() function: * Checks both KV toggle and config.enabled * Triggers when scroll position <= load_threshold pixels from top * Uses existing loadConversationHistory() with ts_before API - Implement updateVisibleMessageViews() for batch tracking: * Updates lastViewed timestamp for all visible messages * Called on scroll events for efficient viewport detection - Add scroll event handlers: * onMouseScroll: triggers auto-load and view tracking * onKeyDown: triggers auto-load on up/pageup/home keys - Add command menu toggle option: * Dynamic title based on current state * Starts/stops cleanup worker on toggle * Uses KV system as designed - Add lifecycle management: * createEffect monitors config and KV toggle * Starts worker when both enabled and session active * onCleanup ensures worker stops on unmount - Import onCleanup from solid-js Complete feature implementation: ~190 lines vs PR anomalyco#8535's ~400 lines
CasualDeveloper
force-pushed
the
feat/6548-message-pagination
branch
from
34eea60 to
2c70c15
Compare
CasualDeveloper
added a commit
to CasualDeveloper/opencode
that referenced
this pull request
Jan 17, 2026
Adds session_list_limit config option to limit sessions displayed in the session list dialog (default: 150). Limit only applies when not searching; search uses server-side limit of 30. Remove message_limit as it conflicts with cursor-based pagination (anomalyco#8535) and is now redundant.
CasualDeveloper
force-pushed
the
feat/6548-message-pagination
branch
from
2c70c15 to
adec748
Compare
…nd navigation Implements cursor-based pagination for message loading to handle long sessions without memory explosion with absolute navigation via Home/End keys. API changes: - Add 'before' cursor param: fetch messages older than cursor (newest first) - Add 'after' cursor param: fetch messages newer than cursor (oldest first) - Add 'oldest' param: start from oldest messages (for jumpToOldest) - Link headers with rel="prev"/"next" for cursor discovery (RFC 5005) TUI changes: - loadOlder/loadNewer actions with sliding window eviction (500 msg limit) - jumpToOldest (Home): fetches oldest page via ?oldest=true - jumpToLatest (End): fetches newest page, preserves revert marker - Detached mode: ignores SSE when viewing history to prevent gaps Implementation: - Binary.lowerBound for efficient cursor lookup - parseLinkHeader utility for RFC 5988 parsing - Message.stream() reverse option for ascending order - Smart parts cleanup: only deletes parts for evicted messages Tests: - Unit tests for pagination logic and cursor handling - API tests for before/after/oldest params and Link headers Resolves: anomalyco#6548
CasualDeveloper
added a commit
to CasualDeveloper/opencode
that referenced
this pull request
Jan 17, 2026
Adds session_list_limit config option to limit sessions displayed in the session list dialog (default: 150). Limit only applies when not searching; search uses server-side limit of 30. Remove message_limit as it conflicts with cursor-based pagination (anomalyco#8535) and is now redundant.
CasualDeveloper
force-pushed
the
feat/6548-message-pagination
branch
from
adec748 to
01e84ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements bi-directional cursor-based pagination for message loading to support long session histories without performance degradation. Closes #6548.
before/after/oldestcursor support with RFC 5005 Link headersContext
Supersedes #6656 by @ry2009 (earlier partial implementation). This PR is a ground-up rewrite that adds:
beforeandaftercursors)oldestparam for jumping to beginning of historyparseLinkHeaderutility instead of brittle string matchingChanges
Backend (
session/index.ts,server/server.ts,message-v2.ts)before,after, andoldestcursor params toSession.messages()ascendingoption toMessageV2.stream()for oldest-first iterationBinary.lowerBoundto util for efficient cursor lookuprel="prev"→ older,rel="next"→ newerTUI (
sync.tsx,routes/session/index.tsx)message_pagestate tracking (hasOlder,hasNewer,loading,error)loadOlder/loadNewerwith scroll position restorationjumpToOldest(Home key) /jumpToLatest(End key) for absolute navigationjumpToLatestpreserves revert marker when jumping to newesthasNewer=true)Tests
messages-pagination.test.tssession-messages.test.tsparse-link-header.test.tsTesting
Related