-
-
Notifications
You must be signed in to change notification settings - Fork 613
feat (/): Chinese translation update #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi! Thank you for submitting a PR :D We really can't merge anything right now as the CI that tests everything before a PR gets merged is broken. We are trying to find a fix as of now. Thanks! |
@ok-coder1 let's rewrite the CI and remove unessary checks. we don't want contirbutions to be stuck. |
got it, thanks <3 |
@anmol098 Do you have a Discord? If yes, please join
https://discord.gg/9UNSmBUKnX
|
@anmol098 @pseusys |
File "/home/runner/work/waka-readme-stats/waka-readme-stats/sources/main.py", line 213, in main
init_github_manager()
~~~~~~~~~~~~~~~~~~~^^
File "/home/runner/work/waka-readme-stats/waka-readme-stats/sources/manager_github.py", line 22, in init_github_manager
GitHubManager.prepare_github_env()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/home/runner/work/waka-readme-stats/waka-readme-stats/sources/manager_github.py", line 52, in prepare_github_env
GitHubManager._REMOTE_NAME = f"{GitHubManager.USER.login}/{GitHubManager.USER.login}"
^^^^^^^^^^^^^^^^^^^^^^^^ This is what's causing the CI to fail. |
- name: Save Branch Name Without Slashes 📛
if: ${{ github.ref != 'refs/heads/master' }}
env:
BRANCH_NAME: ${{ github.head_ref || github.ref_name }}
run: |
BRANCH_NAME=${{ env.BRANCH_NAME }}
BRANCH_NAME=${BRANCH_NAME////_}
echo BRANCH_NAME=${BRANCH_NAME} >> $GITHUB_ENV If I may ask, what's the use of removing slashes from the branch's name? |
As you can see, the branch name is used as a part of an uploaded artefact name - and slashes are not allowed there (but common in branch names). |
translation.json