Skip to content

Conversation

SnowCutieOwO
Copy link

  • Added README translation for Simplified Chinese
  • Smoothed Simplified Chinese texts in translation.json
  • Added missing emoji for Traditional Chinese translation text

@github-actions github-actions bot added documentation Improvements or additions to documentation python Pull requests that update Python code translation Issues/PRs related to translation labels Aug 16, 2025
@SnowCutieOwO SnowCutieOwO mentioned this pull request Aug 16, 2025
@ok-coder1
Copy link
Collaborator

Hi!

Thank you for submitting a PR :D
It means a lot to us.

We really can't merge anything right now as the CI that tests everything before a PR gets merged is broken.
The CI is required to not fail in order to merge.

We are trying to find a fix as of now.

Thanks!
Regards, okcoder1

@anmol098
Copy link
Owner

@ok-coder1 let's rewrite the CI and remove unessary checks. we don't want contirbutions to be stuck.

@SnowCutieOwO
Copy link
Author

Hi!

Thank you for submitting a PR :D It means a lot to us.

We really can't merge anything right now as the CI that tests everything before a PR gets merged is broken. The CI is required to not fail in order to merge.

We are trying to find a fix as of now.

Thanks! Regards, okcoder1

got it, thanks <3

@ok-coder1 ok-coder1 removed the python Pull requests that update Python code label Aug 16, 2025
@ok-coder1
Copy link
Collaborator

ok-coder1 commented Aug 16, 2025 via email

@ok-coder1
Copy link
Collaborator

@ok-coder1 let's rewrite the CI and remove unessary checks. we don't want contirbutions to be stuck.

@anmol098 @pseusys
The CI is not able to get repository secrets (AFAIK) and pull_request_target takes code from the default branch, which makes it so that the CI can't test code from contributors' forks.

@ok-coder1
Copy link
Collaborator

  File "/home/runner/work/waka-readme-stats/waka-readme-stats/sources/main.py", line 213, in main
    init_github_manager()
    ~~~~~~~~~~~~~~~~~~~^^
  File "/home/runner/work/waka-readme-stats/waka-readme-stats/sources/manager_github.py", line 22, in init_github_manager
    GitHubManager.prepare_github_env()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/home/runner/work/waka-readme-stats/waka-readme-stats/sources/manager_github.py", line 52, in prepare_github_env
    GitHubManager._REMOTE_NAME = f"{GitHubManager.USER.login}/{GitHubManager.USER.login}"
                                    ^^^^^^^^^^^^^^^^^^^^^^^^

This is what's causing the CI to fail.

@ok-coder1
Copy link
Collaborator

      - name: Save Branch Name Without Slashes 📛
        if: ${{ github.ref != 'refs/heads/master' }}
        env:
          BRANCH_NAME: ${{ github.head_ref || github.ref_name }}
        run: |
          BRANCH_NAME=${{ env.BRANCH_NAME }}
          BRANCH_NAME=${BRANCH_NAME////_}
          echo BRANCH_NAME=${BRANCH_NAME} >> $GITHUB_ENV

If I may ask, what's the use of removing slashes from the branch's name?

@pseusys
Copy link
Collaborator

pseusys commented Sep 2, 2025

      - name: Save Branch Name Without Slashes 📛

        if: ${{ github.ref != 'refs/heads/master' }}

        env:

          BRANCH_NAME: ${{ github.head_ref || github.ref_name }}

        run: |

          BRANCH_NAME=${{ env.BRANCH_NAME }}

          BRANCH_NAME=${BRANCH_NAME////_}

          echo BRANCH_NAME=${BRANCH_NAME} >> $GITHUB_ENV

If I may ask, what's the use of removing slashes from the branch's name?

As you can see, the branch name is used as a part of an uploaded artefact name - and slashes are not allowed there (but common in branch names).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation translation Issues/PRs related to translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants