Skip to content

Verbose logging environmental variable added #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 26, 2023
Merged

Verbose logging environmental variable added #381

merged 7 commits into from
Feb 26, 2023

Conversation

@pseusys
Copy link
Collaborator

@pseusys pseusys commented Feb 22, 2023 •
edited
Loading

This pull request will include:

  • Verbose logging on request
  • Local dry running possibility, saving data locally instead of saving
  • New CI/CD system, running action on each push, saving results as artifact

Closes #377

@pseusys pseusys added the enhancement New feature or request label Feb 22, 2023
@pseusys pseusys self-assigned this Feb 22, 2023
@anmol098
Copy link
Owner

@pseusys i have pushed minor tweak to logging maybe i messed with codestyle. please have a look for resolving the checks

@pseusys
Copy link
Collaborator Author

pseusys commented Feb 25, 2023

Is it ready to merge?

@pseusys pseusys marked this pull request as ready for review February 25, 2023 18:52
pseusys referenced this pull request Feb 25, 2023
@pseusys
download manager improved to handle and cache all kinds of requests
887ff2b
@anmol098 anmol098 self-requested a review February 25, 2023 21:27
anmol098
anmol098 approved these changes Feb 25, 2023
View reviewed changes
Copy link
Owner

@anmol098 anmol098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;
this can be merged first post that #384 can be reviewed and merged

@pseusys pseusys merged commit e1576ed into master Feb 26, 2023
@pseusys pseusys deleted the feat/verbose_tests_and_dry_running branch February 26, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmol098 anmol098 anmol098 approved these changes

Assignees

@pseusys pseusys

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add CI / CD system to this repository

3 participants

@pseusys @anmol098