Skip to content

fix: Issue with insecure TLS config #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2022
Merged

fix: Issue with insecure TLS config #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions internal/config/generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ type JiraCLIConfigGenerator struct {
issueTypes []*jira.IssueType
customFields []*issueTypeFieldConf
}
insecure bool
jiraClient *jira.Client
projectSuggestions []string
boardSuggestions []string
Expand Down Expand Up @@ -279,7 +278,7 @@ func (c *JiraCLIConfigGenerator) verifyLoginDetails(server, login string) error
c.jiraClient = api.Client(jira.Config{
Server: server,
Login: login,
Insecure: c.insecure,
Insecure: c.usrCfg.Insecure,
AuthType: c.value.authType,
Debug: viper.GetBool("debug"),
})
Expand Down Expand Up @@ -535,8 +534,8 @@ func (c *JiraCLIConfigGenerator) write(path string) (string, error) {
config.SetConfigName(FileName)
config.SetConfigType(FileType)

if c.insecure {
config.Set("insecure", c.insecure)
if c.usrCfg.Insecure {
config.Set("insecure", c.usrCfg.Insecure)
}

config.Set("installation", c.value.installation)
Expand Down