Skip to content

Conversation

GZLiew
Copy link
Contributor

@GZLiew GZLiew commented Mar 10, 2022

This PR add refreshing behaviour when the <C-R> or F5 key is pressed when viewing issues list

relating to #292 but with no interval implemented

Copy link
Owner

@ankitpokhrel ankitpokhrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GZLiew, Thank you for working on this 🙌🏻

I wanted to do this differently but that would require some rework on how the TUI is implemented. So, I think your approach is fine for now and I will improve it later.

I do have some comments tho.

  1. Let's use standard CTRL + R / F5 as a shortcut for refreshing.
  2. Could you please extend this to jira epic list <epic_id> and jira sprint list <sprint_id>?

Thank you!

Copy link
Contributor

@adolsalamanca adolsalamanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work 👍🏽 (just another random contributor here)
Could you please update Readme and comments so they stay up to date with latest shortcuts used?

Copy link
Owner

@ankitpokhrel ankitpokhrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this @GZLiew and thank you for reviewing @adolsalamanca, it helps! 🎉

@ankitpokhrel ankitpokhrel merged commit 8fe2b39 into ankitpokhrel:main Mar 22, 2022
@ankitpokhrel ankitpokhrel added this to the v1.0.0 milestone Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants