Skip to content

fix(player): Dismiss chapter sheet on chapter select #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

fix(player): Dismiss chapter sheet on chapter select #1976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/eu/kanade/tachiyomi/ui/player/PlayerViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ class PlayerViewModel @JvmOverloads constructor(
_areControlsLocked.update { false }
}

private fun dismissSheet() {
fun dismissSheet() {
_dismissSheet.update { _ -> true }
}

Expand Down
1 change: 1 addition & 0 deletions app/src/main/java/eu/kanade/tachiyomi/ui/player/controls/PlayerControls.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,7 @@ fun PlayerControls(
chapters = chapters.map { it.toSegment() }.toImmutableList(),
onSeekToChapter = {
viewModel.selectChapter(it)
viewModel.dismissSheet()
viewModel.unpause()
},
decoder = decoder,
Expand Down
3 changes: 2 additions & 1 deletion app/src/main/java/eu/kanade/tachiyomi/ui/player/controls/PlayerSheets.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ fun PlayerSheets(
chapters,
currentChapter = chapter,
onClick = { onSeekToChapter(chapters.indexOf(it)) },
onDismissRequest,
onDismissRequest = onDismissRequest,
dismissSheet = dismissSheet,
)
}

Expand Down
2 changes: 2 additions & 0 deletions app/src/main/java/eu/kanade/tachiyomi/ui/player/controls/components/sheets/ChaptersSheet.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ fun ChaptersSheet(
currentChapter: Segment,
onClick: (Segment) -> Unit,
onDismissRequest: () -> Unit,
dismissSheet: Boolean,
modifier: Modifier = Modifier,
) {
GenericTracksSheet(
Expand All @@ -55,6 +56,7 @@ fun ChaptersSheet(
)
},
onDismissRequest = onDismissRequest,
dismissEvent = dismissSheet,
modifier = modifier
.padding(vertical = MaterialTheme.padding.medium),
)
Expand Down