static transform naming convention #1
Description
A static transform publisher publishes a transform from parent frame_id to child child_frame_id. In other words, it broadcasts child frame with respect to parent frame. Therefore, I think the transform name convention of
"parent_child_broadcaster" or "child_broadcaster" gives the clear meaning of what is stored in that transform variable and which frame is being broadcasted. A third user may just assume that the meaningful variable name A_B_broadcaster represents the transform from frame A to frame B.
However, during static review, I observed that in the launch files, e.g., mono_odometer.launch, the transform name at line 10, camera_baselink_broadcaster, uses a reversed transform name convention of "child_parent_broadcaster". This does not reflect the actual transform that is being broadcasted. The name baselink_camera_broadcaster would be more appropriate.
Would really appreciate if you could please describe your perspective behind using this "child_parent_broadcaster" naming convention, and your views on its effects on code reuse in future.
Thank you!