Experimental: Add CGS and FPS unit systems #630
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Seems they aren't specified! I could relax the fully defined for UnitSystems. But not all conversions will succeed. |
Owner
Author
|
Should also look into adding British Engineering units and English Engineering units, as a proof of concept. |
Owner
Author
|
Closing this for now until #651 discussion moves forward. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the previous PR, I figured adding these CGS and FPS unit systems would be a breeze.
It did not take long to stop me in my tracks. I truly am lost on what units to designate the 7 base units for CGS and FPS unit systems. Do you have some ideas on how to proceed here?
I couldn't find much information about the units and it almost seems like there is no 1:1 mapping between SI base units concept and CGS/FPS. For instance, in CGS there is a table for converting from SI electric units to CGS units in ESU/EMU/Gauss systems - so maybe CSG is just a group of systems sharing those three base units and ESU/EMU/Gauss are really the systems we should consider adding instead?
https://no.wikipedia.org/wiki/CGS-systemet (Norwegian wiki)
I don't know. Maybe these systems are so old no one will care about them being available either. I'm just eager to add something more than just SI to help showcase the value of various unit systems, which is yet a fairly abstract concept to me.
Update:
After maturing this thought a bit, I think our current
UnitSystemdesign needs a little bit of rethink. It is currently an SI unit system, with 7 SI base units. Other unit systems don't define all those units or define entirely different units. See #651 for discussion.