Skip to content

Removing the SupportsSIUnitSystem => true property overrides #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lipchev wants to merge 3 commits into from
Closed

Removing the SupportsSIUnitSystem => true property overrides #1534

lipchev wants to merge 3 commits into from

Conversation

@lipchev
Copy link
Collaborator

@lipchev lipchev commented Apr 11, 2025

fixes #1463

@lipchev
Copy link
Collaborator Author

lipchev commented Apr 11, 2025

As expected, there are only the

  • ElectricApparentEnergy
  • ElectricReactiveEnergy
  • FuelEfficiency

which override this property (and also [Skip] the corresponding tests). The only other tests that are skipped are for the BaseUnit_HasSIBase (as noted in the linked issue).

@angularsen angularsen deleted the branch angularsen:release/v6 April 11, 2025 10:30
@angularsen angularsen closed this Apr 11, 2025
@lipchev lipchev mentioned this pull request Apr 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lipchev @angularsen