Fix force conversion rates #1308
Merged
+156
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takes the rate from kilograms and divides it by the rate from newtons Standard gravity is stated as being 9.80665 m/s2
Opt to have the compiler calculate the expected value
angularsen
requested changes
Aug 21, 2023
Owner
angularsen
left a comment
angularsen
left a comment
There was a problem hiding this comment.
Very nice, just a few minor things to look at.
Owner
|
Will get to this soon |
angularsen
added
the
pending-response
Owner
|
Thanks! A lot of great improvements here. Release UnitsNet/5.33.0 · angularsen/UnitsNet Now that this is merged, I can put my attention to #1309 the next time I find some free time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1306
Corrects the conversion rates of the force quantity to be the precisely defined values, relative to standard gravity.
Adds a unit test that verifies that the conversion rate from kilograms divided by the conversion rate from newtons equals standard gravity (
9.80665m/s2).